refactor(card-browser): AppBar methods

* `updateAppBarInfo` should is called `onDeckIdChanged`
  so it should not be necessary onCollectionLoaded
* inline numberOfCardsOrNoteShown
* split into deck name changed and count changed
* inline into onDeckIdChanged

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

@@ -478,7 +478,15 @@ open class CardBrowser :
         }
 
         fun onDeckIdChanged(deckId: DeckId?) {
-            updateAppBarInfo(deckId)
+            if (useSearchView) return
+            launchCatchingTask {
+                findViewById<TextView>(R.id.deck_name)?.text =
+                    when (deckId) {
+                        null -> getString(R.string.card_browser_all_decks)
+                        ALL_DECKS_ID -> getString(R.string.card_browser_all_decks)
+                        else -> withCol { decks.getLegacy(deckId)?.name }
+                    }
+            }
         }
 
         fun onMultiSelectModeChanged(modeChange: ChangeMultiSelectMode) {
@@ -514,7 +522,8 @@ open class CardBrowser :
                 }
                 is SearchState.Completed -> {
                     Timber.i("CardBrowser:: Completed searchCards() Successfully")
-                    updateAppBarInfo(viewModel.deckId)
+                    // TODO: obtain these values from 'Completed'
+                    findViewById<TextView>(R.id.subtitle)?.text = formatCardCount(viewModel.rowCount, viewModel.cardsOrNotes)
                     // HACK: required now we use MenuProvider for searches
                     // this causes a very brief flicker, as we call `setQuery` to restore the menu state
                     searchView?.post { searchView?.clearFocus() }
@@ -602,7 +611,6 @@ open class CardBrowser :
         registerReceiver()
 
         window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_HIDDEN)
-        updateAppBarInfo(viewModel.deckId)
     }
 
     override fun onKeyUp(
@@ -816,12 +824,6 @@ open class CardBrowser :
         }
     }
 
-    /**
-     * @return A message stating the number of cards/notes shown by the browser.
-     */
-    val numberOfCardsOrNoteShown: String
-        get() = formatCardCount(viewModel.rowCount, viewModel.cardsOrNotes)
-
     fun formatCardCount(
         count: Int,
         cardsOrNotes: CardsOrNotes,
@@ -916,23 +918,6 @@ open class CardBrowser :
     override val shortcuts
         get() = cardBrowserFragment.shortcuts
 
-    /**
-     * Sets the selected deck name and current selection count based on [numberOfCardsOrNoteShown]
-     */
-    private fun updateAppBarInfo(deckId: DeckId?) {
-        if (useSearchView) return
-        findViewById<TextView>(R.id.subtitle)?.text = numberOfCardsOrNoteShown
-        launchCatchingTask {
-            val deckName =
-                when (deckId) {
-                    null -> getString(R.string.card_browser_all_decks)
-                    ALL_DECKS_ID -> getString(R.string.card_browser_all_decks)
-                    else -> withCol { decks.getLegacy(deckId)?.name }
-                }
-            findViewById<TextView>(R.id.deck_name)?.text = deckName
-        }
-    }
-
     // region MenuHost delegation
 
     // This only supports delegation of menus defined using MenuProvider, not `onCreateOptionsMenu`