refactor(card-browser): simplify no-op setters

Assisted-by: Claude Opus 4.7 - all

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/BrowserOptionsRepository.kt

@@ -47,18 +47,21 @@ class BrowserOptionsRepository(
     }
 
     suspend fun setCardsOrNotes(value: CardsOrNotes) {
+        if (cardsOrNotes.value == value) return
         Timber.i("setting cards/notes mode to %s", value)
         withCol { value.saveToCollection(this) }
         cardsOrNotes.value = value
     }
 
     fun setIsTruncated(value: Boolean) {
+        if (isTruncated.value == value) return
         Timber.d("setting truncated to %s", value)
         sharedPrefs.edit { putBoolean(PREF_IS_TRUNCATED, value) }
         isTruncated.value = value
     }
 
     suspend fun setIgnoreAccentsInSearch(value: Boolean) {
+        if (ignoreAccentsInSearch.value == value) return
         Timber.d("setting ignore accents in search to %s", value)
         withCol { config.ignoreAccentsInSearch = value }
         ignoreAccentsInSearch.value = value

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/BrowserOptionsDialog.kt

@@ -49,19 +49,9 @@ class BrowserOptionsDialog : AppCompatDialogFragment(R.layout.dialog_browser_opt
 
     /** Persists updated options to the ViewModel */
     fun saveChanges() {
-        if (cardsOrNotes != dialogCardsOrNotes) {
-            viewModel.setCardsOrNotes(dialogCardsOrNotes)
-        }
-        val newTruncate = binding.truncateCheckBox.isChecked
-
-        if (newTruncate != isTruncated) {
-            viewModel.setTruncated(newTruncate)
-        }
-
-        val newIgnoreAccent = binding.ignoreAccentsCheckBox.isChecked
-        if (newIgnoreAccent != viewModel.shouldIgnoreAccents) {
-            viewModel.setIgnoreAccents(newIgnoreAccent)
-        }
+        viewModel.setCardsOrNotes(dialogCardsOrNotes)
+        viewModel.setTruncated(binding.truncateCheckBox.isChecked)
+        viewModel.setIgnoreAccents(binding.ignoreAccentsCheckBox.isChecked)
     }
 
     private val cardsOrNotes by lazy {