refactor(card-browser): browser destination

* ToCard => ScrollToCard
* Move EXTRA_CARD_ID_KEY to ViewModel

This should be a responsibility of the browser, not the destination

Assisted-by: Claude Opus 4.7 - all

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/BrowserDestination.kt

@@ -37,21 +37,17 @@ sealed interface BrowserDestination : Destination {
     }
 
     /**
-     * Opens the [CardBrowser] with the specified deck selected,
-     * and automatically scrolls to [cardId] if the card is present on the deck.
+     * Opens the [CardBrowser] scoped to [deckId], auto-scrolling to [cardId]
+     * if the card is present on the deck.
      */
-    data class ToCard(
+    data class ScrollToCard(
         val deckId: DeckId,
         val cardId: CardId,
     ) : BrowserDestination {
         override fun toIntent(context: Context): Intent =
             Intent(context, CardBrowser::class.java).apply {
                 putExtra(CardBrowserViewModel.EXTRA_DECK_ID, deckId)
-                putExtra(EXTRA_CARD_ID_KEY, cardId)
+                putExtra(CardBrowserViewModel.EXTRA_CARD_ID_KEY, cardId)
             }
-
-        companion object {
-            const val EXTRA_CARD_ID_KEY = "cardId"
-        }
     }
 }

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserLaunchOptions.kt

@@ -54,7 +54,7 @@ fun Intent.toCardBrowserLaunchOptions(): CardBrowserLaunchOptions? {
         return CardBrowserLaunchOptions.SearchQueryJs(it, getBooleanExtra("all_decks", false))
     }
 
-    getLongExtra(BrowserDestination.ToCard.EXTRA_CARD_ID_KEY)?.let { cardId ->
+    getLongExtra(CardBrowserViewModel.EXTRA_CARD_ID_KEY)?.let { cardId ->
         return CardBrowserLaunchOptions.ScrollToCard(cardId)
     }
 

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserViewModel.kt

@@ -1430,6 +1430,9 @@ class CardBrowserViewModel(
         /** Intent extra carrying the [DeckId] the browser should open scoped to. */
         const val EXTRA_DECK_ID = "deckId"
 
+        /** Intent extra carrying a [CardId] to auto-scroll to once the browser opens. */
+        const val EXTRA_CARD_ID_KEY = "cardId"
+
         /** Prevents one-shot extras from being re-applied after process death. */
         private const val STATE_LAUNCH_INTENT_CONSUMED = "launchIntentConsumed"
 

AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerViewModel.kt

@@ -346,7 +346,7 @@ class ReviewerViewModel(
     private suspend fun emitBrowseDestination() {
         val deckId = withCol { decks.getCurrentId() }
         val cardId = currentCard.await().id
-        val destination = BrowserDestination.ToCard(deckId, cardId)
+        val destination = BrowserDestination.ScrollToCard(deckId, cardId)
         Timber.i("Launching 'browse options' for deck %d", deckId)
         destinationFlow.emit(destination)
     }