refactor: getAppSpecificExternalAnkiDroidDirectory return value

david-allison · david-allison · commit cbe4d38007cd · 2026-07-06T01:26:22.000+01:00
Assisted-by: Claude Fable 5
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/startup/SetupStorage.kt b/AnkiDroid/src/main/java/com/ichi2/anki/startup/SetupStorage.kt
@@ -156,7 +156,7 @@ private fun legacyAnkiDroidDirectory(directoryName: String = "AnkiDroid"): File
  *
  * @throws SystemStorageException if `getExternalFilesDir` returns null
  */
-private fun getAppSpecificExternalAnkiDroidDirectory(context: Context): String? {
+private fun getAppSpecificExternalAnkiDroidDirectory(context: Context): String {
     val externalFilesDir = context.getExternalFilesDir(null)
 
     // This value *may* be null but we strictly require it. This has caused NullPointerException

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ private fun legacyAnkiDroidDirectory(directoryName: String = "AnkiDroid"): File`
`156`	`156`	`*`
`157`	`157`	* @throws SystemStorageException if `getExternalFilesDir` returns null
`158`	`158`	`*/`
`159`		`-private fun getAppSpecificExternalAnkiDroidDirectory(context: Context): String? {`
	`159`	`+private fun getAppSpecificExternalAnkiDroidDirectory(context: Context): String {`
`160`	`160`	`val externalFilesDir = context.getExternalFilesDir(null)`
`161`	`161`
`162`	`162`	`// This value may be null but we strictly require it. This has caused NullPointerException`