Architecture Review: ViewBindings

[david-allison]

This exists so maintainers can see the type of changes I'm performing for ViewBinding and set patterns before I split them out into reviewable chunks. This should not be merged

• Add View Binding ankidroid/Anki-Android#11116

[david-allison]

The following is causing Deck name gravity issues in the DeckPicker:

chore: convert DeckAdapter.ViewHolder to ViewBinding - 9b9ce78

[david-allison]

setViewBinding is currently needed in NavigationDrawerActivity, and it felt sensible to have a 'standard' pattern for all activities

We only override setContentView(R.layout), and it feels like the point of ViewBindings is to move away from R.layout references where possible

[lukstbit]

I understand, I saw the method and how it was used and went to the commit to comment on it without scrolling a bit below to see the actual usage:)

it feels like the point of ViewBindings is to move away from R.layout references where possible

I don't see any issues with that, the only reason I would use view binding is for the null safety.

[lukstbit]

Another lib example, not maintained but maybe it could be useful.

[david-allison]

Zhuinden is still active