Reminder troubleshooting - for review by david-allison · Pull Request #50 · david-allison/Anki-Android

david-allison · 2026-04-11T07:02:43Z

Work in progress. This won't be in this repo and will be recreated for Anki-Android.

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

@Suppress

- ImportEntry was a data class with @Suppress(ArrayInDataClass) on top, but none of the data class features (equals, hashCode, copy, componentN, toString) were ever used. Drop the data keyword, the suppression, and the stale comment. Also tighten to since it is never reassigned.

Assisted-by: Claude Opus 4.6

And add tests There is a bug here, and tests make this bug obvious Assisted-by: Claude Opus 4.6

If the user is retrying a call to 'sync' due to wanting to do a full upload/download, then do not show the metered sync dialog again Fixes 20674 Assisted-by: Claude Opus 4.6

Assisted-by: Claude Opus 4.6

Technically a bugfix, but since the code only ran `onCreate`, it was never a practical issue. Also allows us to use `applied` to simplify the logic But it allows us to trim code in the DeckPicker

We did not follow a common pattern

Fixes BackendCollectionAlreadyOpenException init { } ran code, but the coroutines were not cancelled Fixes 20704

testFixtures were introduced in fbf2dd0 This allows us to remove a module

…AS_REIFIED` error caused by KT-74516

In multiselect mode... User request - delete is normally on the bottom I left it above 'undo'

This checks the 'main' issue: permission has not been granted Assisted-by: Claude Opus 4.6

Study reminders are not important enough for us to want to break Do not Disturb But we should warn users that reminders may be silenced due to it Influenced by Daylio - they also perform this check https://developer.android.com/develop/ui/views/notifications#dnd-mode Assisted-by: Claude Opus 4.6

Battery optimization makes it less likely for an app to wake and post a notification. There are 3 statuses: * Unrestricted * Optimized - Default * Restricted Since 'Optimized' is the default, and the 'obvious' Android UI encourages a user to change this to 'Restricted', Optimized is a warning and 'Restricted' is an error, to showcase to a user that they have made things worse Influenced by Daylio - they also perform this check https://developer.android.com/training/monitoring-device-state/doze-standby#support_for_other_use_cases Assisted-by: Claude Opus 4.6

A user can request `Manifest.permission.SCHEDULE_EXACT_ALARM` on API 31+ which allows scheduling of exact alarms. We do not currently support this in the manifest, but we should do before launch https://developer.android.com/about/versions/14/changes/schedule-exact-alarms Influenced by Daylio - they also perform this check Assisted-by: Claude Opus 4.6

Power saving can delay notifications being fired. OEMs have different restrictions on Android when this feature is enabled In addition: Doze mode can defer AlarmManager calls unless a `set...AndAllowWhenIdle` call is made. https://developer.android.com/training/monitoring-device-state/doze-standby Influenced by Daylio - they also perform this check Assisted-by: Claude Opus 4.6

We want to notify the UI about the general status of our troubleshooting checks, so we can know: * If reminders are broken * If reminders may not work * If reminders are likely working Assisted-by: Claude Opus 4.6

ericli3690

Only nits, looks amazing, ship it 🔥

ericli3690 · 2026-04-11T20:29:28Z

+                android:gravity="center"
+                android:textAppearance="?attr/textAppearanceBodyMedium"
+                android:textColor="?android:attr/textColorSecondary"
+                tools:text="Everything looks good! Your reminders should work as expected." />


nice, we'll yank these guys out into separate strings once everything is stable 🔥
Although I think this string here never actually shows up since it gets overridden programmatically

ericli3690 · 2026-04-11T20:44:59Z

+// TODO: convert error icon to outline
+private fun CheckResult.iconRes(): Int =


Similarly, consider moving this to where CheckResult is defined

ericli3690 · 2026-04-11T21:08:53Z

Actually on second thought don't forget:

See the UI bug I pointed out in our DMs
Lint is failing :(

`CollectionLoadingErrorDialog().toMessage()` was incorrect introduced in 6ba468e Fixes 20712 Assisted-by: Calude Opus 4.6

Part of issue 19896

For now, this only shows the status, not the checks * Adds a menu item on reminders to open troubleshooting * Display the overall status of checks Assisted-by: Claude Opus 4.6

Assisted-by: Claude Opus 4.6

Allow a user to tap a troubleshooting issue and open an appropriate screen to fix the issue Assisted-by: Claude Opus 4.6

criticalAY and others added 15 commits April 8, 2026 20:21

Updated strings from Crowdin

90219a3

Improve the custom sync server dialogs

0c19c86

Updated strings from Crowdin

64be798

refactor(deck-picker): extract 'MeteredSyncPolicy'

db1309d

Assisted-by: Claude Opus 4.6

refactor(deck-picker): extract metered sync logic

30a58c3

And add tests There is a bug here, and tests make this bug obvious Assisted-by: Claude Opus 4.6

fix(deck-picker): metered sync retry logic

73af0c2

If the user is retrying a call to 'sync' due to wanting to do a full upload/download, then do not show the metered sync dialog again Fixes 20674 Assisted-by: Claude Opus 4.6

refactor(deck-picker): extract background image

56048ea

Assisted-by: Claude Opus 4.6

fix(deck-picker): use setImageDrawable

08650b7

Technically a bugfix, but since the code only ran `onCreate`, it was never a practical issue. Also allows us to use `applied` to simplify the logic But it allows us to trim code in the DeckPicker

test: add input length validation tests for SetDueDateDialog

306e715

refactor: PreviewerViewModelTest setup

913f19e

We did not follow a common pattern

fix: flaky tests in PreviewerViewModelTest

6da3cdf

Fixes BackendCollectionAlreadyOpenException init { } ran code, but the coroutines were not cancelled Fixes 20704

architecture: convert libanki:testutils to testFixtures

6147047

testFixtures were introduced in fbf2dd0 This allows us to remove a module

Specify array type in LayoutValidationTest to fix `TYPE_INTERSECTION_…

d3c3091

…AS_REIFIED` error caused by KT-74516

Add test for updateSelectDeck function

0027ec4

github-actions Bot added the Needs Review label Apr 11, 2026

david-allison force-pushed the reminder_troubleshooting branch from 511b8a3 to 378cb2d Compare April 11, 2026 07:04

david-allison added 7 commits April 11, 2026 07:14

feat(card-browser): move 'delete notes' to bottom

bab4958

In multiselect mode... User request - delete is normally on the bottom I left it above 'undo'

feat(reminders): viewmodel for troubleshooting

04f4137

This checks the 'main' issue: permission has not been granted Assisted-by: Claude Opus 4.6

feat(reminders): troubleshooting: overall status

1bae387

We want to notify the UI about the general status of our troubleshooting checks, so we can know: * If reminders are broken * If reminders may not work * If reminders are likely working Assisted-by: Claude Opus 4.6

ericli3690 approved these changes Apr 11, 2026

View reviewed changes

david-allison added 2 commits April 12, 2026 03:45

fix: crash from ShowDatabaseErrorDialog.fromMessage

bdb85a3

`CollectionLoadingErrorDialog().toMessage()` was incorrect introduced in 6ba468e Fixes 20712 Assisted-by: Calude Opus 4.6

refactor: standardize bundle arg constant names

7902984

Part of issue 19896

david-allison force-pushed the reminder_troubleshooting branch 2 times, most recently from 672929b to 31032f6 Compare April 12, 2026 09:43

david-allison force-pushed the reminder_troubleshooting branch 2 times, most recently from 6d2c63a to 57e47eb Compare April 12, 2026 10:07

david-allison added 3 commits April 12, 2026 11:09

feat(reminders): add troubleshooting screen

1626829

For now, this only shows the status, not the checks * Adds a menu item on reminders to open troubleshooting * Display the overall status of checks Assisted-by: Claude Opus 4.6

feat(reminders): display troubleshooting checks

3a3b398

Assisted-by: Claude Opus 4.6

feat(reminders): troubleshooting issue fixes

6066a85

Allow a user to tap a troubleshooting issue and open an appropriate screen to fix the issue Assisted-by: Claude Opus 4.6

david-allison force-pushed the reminder_troubleshooting branch from 57e47eb to 6066a85 Compare April 12, 2026 10:09

david-allison closed this Apr 12, 2026

david-allison mentioned this pull request Apr 12, 2026

feat(reminders): reminder troubleshooting UI [DEV-Only] ankidroid/Anki-Android#20724

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reminder troubleshooting - for review #50

Reminder troubleshooting - for review #50
david-allison wants to merge 27 commits intomainfrom
reminder_troubleshooting

david-allison commented Apr 11, 2026 •

edited

Loading

Uh oh!

ericli3690 left a comment

Uh oh!

ericli3690 Apr 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericli3690 Apr 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericli3690 commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		// TODO: convert error icon to outline
		private fun CheckResult.iconRes(): Int =

Uh oh!

Conversation

david-allison commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ericli3690 left a comment

Choose a reason for hiding this comment

Uh oh!

ericli3690 Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericli3690 Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericli3690 commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

david-allison commented Apr 11, 2026 •

edited

Loading