Deploying test#10
Merged
Merged
Conversation
Update examples/docker-compose.yml to set explicit build contexts and Dockerfile paths for backend and frontend services so they build correctly from the repository root. This ensures Docker uses the example subdirectories as the build context rather than the compose file location.
Update examples/docker-compose.yml to use './backend' and './frontend' as the build contexts instead of 'examples/backend' and 'examples/frontend'. This makes the paths relative to the compose file and aligns the compose configuration with the repository layout.
Rename examples/docker-compose.yml to docker-compose.yml and update the Docker build contexts to examples/backend and examples/frontend. Ports and VITE_BACKEND_URL arg are unchanged. This centralizes the compose file at the repository root and corrects paths after the move.
Replace explicit allowed origins with setAllowedOriginPatterns(List.of("*")) to allow wildcard origins. This simplifies CORS for the demo backend (supports dynamic/dev hosts) and is compatible with allowCredentials; other CORS settings remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the demo environment setup, including updates to Docker configuration, CORS policy, and frontend dependencies. The changes aim to streamline local development and ensure permissive access for demo purposes.
Docker and Environment Configuration:
examples/docker-compose.ymltodocker-compose.ymland updated thebackendandfrontendservice build contexts to use theexamplesdirectory, specifying theDockerfileexplicitly for each.CORS Policy for Demo Backend:
CorsConfig.javato allow all origins by settingallowedOriginPatternsto*, making it easier to access the backend from any frontend during demos.Frontend Dependency Updates:
@emnapi/wasi-threadspackage from version1.2.0to1.2.1inexamples/frontend/package-lock.jsonto ensure the latest fixes and improvements.