Commit 770320f
fix(ui-patterns): fix password-strength false positive on hard refresh
The "Weak password shows low strength" test passed with blanked starter
because `[] / 5 * 100 = 0` (JS coercion) and the test only checked
`< 50`. Fixed by: (1) requiring `> 0 && < 50` in the test so 0% width
from an unimplemented starter doesn't pass, (2) adding .length/.size
override in the generator so `rules.filter(...).length` produces `0`
not `[]` as default, (3) regenerating starters.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent 3911a68 commit 770320f
4 files changed
Lines changed: 10 additions & 4 deletions
File tree
- lib/frontend-drills/ui-patterns
- starters
- tests
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
922 | 922 | | |
923 | 923 | | |
924 | 924 | | |
925 | | - | |
| 925 | + | |
926 | 926 | | |
927 | 927 | | |
928 | 928 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
237 | 239 | | |
238 | 240 | | |
239 | 241 | | |
| |||
473 | 475 | | |
474 | 476 | | |
475 | 477 | | |
476 | | - | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
477 | 483 | | |
478 | 484 | | |
479 | 485 | | |
| |||
0 commit comments