KISS: be a thinner layer over the Discount library#49
Open
sunaku wants to merge 3 commits intodavidfstr:masterfrom
Open
KISS: be a thinner layer over the Discount library#49sunaku wants to merge 3 commits intodavidfstr:masterfrom
sunaku wants to merge 3 commits intodavidfstr:masterfrom
Conversation
This is necessary to enable the MKD_NOPANTS flag in the underlying Discount library; otherwise the Markdown test suite will fail.
Owner
|
Sounds like a useful design change. I will consider this for RDiscount 3.x. |
Author
|
Awesome! I'm looking forward to having this merged into RDiscount 3.x. 😺 |
Owner
|
13 years later... RDiscount 3.x may be coming soon (in the next few months), now that Discount 2.x has trouble building on modern compilers. Therefore I will take another look at this PR again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits make RDiscount a thinner layer over the Discount library. They introduce the following backwards-incompatible changes:
RDiscountclass were replaced by a singleRDiscount#flagsaccessor which just contains the raw integer bit flags that are passed directly to the underlying Discount library.RDiscountclass.RDISCOUNT_EXTENSIONSallows people to choose the set of RDiscount extensions and Discount flags that they want to enable at the command-line.Cheers.