feat: update event invoke config with alias

[ojongerius]

Proposed changes

This change updates the EventInvokeConfig to point to the alias created. This means that Destinations, MaximumEventAgeInSeconds and MaximumRetryAttempts were previously only applied to the unqualified ARN instead of the alias.

Types of changes

What types of changes does your code introduce to the plugin?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[ojongerius]

One thing to mentioned might be, I'm updating instead of adding the EventInvokeConfig. When adding an EventInvokeConfig for both unqualified and an alias, the Cloudformation validation will pass but AWS will only create one EventInvokeConfig -in this case for the unqualified only.

When generating these snippets of CF template:

    "HelloLambdaEvConfAlias": {
      "Type": "AWS::Lambda::EventInvokeConfig",
      "Properties": {
        "FunctionName": {
          "Ref": "HelloLambdaFunction"
        },
        "DestinationConfig": {
          "OnFailure": {
            "Destination": "arn:aws:sqs:ap-southeast-2:123456789:dev-primary-dlq"
          }
        },
        "Qualifier": "live",
        "MaximumEventAgeInSeconds": 1800,
        "MaximumRetryAttempts": 2
      },
      "DependsOn": "HelloWorldFunctionAliaslive"
    }

and

    "HelloLambdaEvConf": {
      "Type": "AWS::Lambda::EventInvokeConfig",
      "Properties": {
        "FunctionName": {
          "Ref": "HelloLambdaFunction"
        },
        "DestinationConfig": {
          "OnFailure": {
            "Destination": "arn:aws:sqs:ap-southeast-2:123456789:dev-primary-dlq"
          }
        },
        "Qualifier": "$LATEST",
        "MaximumEventAgeInSeconds": 1800,
        "MaximumRetryAttempts": 2
      }
    }

AWS actually would only create an Ev config for for the unqualified function:

▶ aws lambda get-function-event-invoke-config --function-name hello                 
{
    "LastModified": "2022-09-01T11:03:11.647000+12:00",
    "FunctionArn": "arn:aws:lambda:ap-southeast-2:123456789:function:hello:$LATEST",
    "MaximumRetryAttempts": 2,
    "MaximumEventAgeInSeconds": 1800,
    "DestinationConfig": {
        "OnSuccess": {},
        "OnFailure": {
            "Destination": "arn:aws:sqs:ap-southeast-2:123456789:dev-primary-dlq"
        }
    }
}

But not the alias:

▶ aws lambda get-function-event-invoke-config --function-name hello --qualifier live

An error occurred (ResourceNotFoundException) when calling the GetFunctionEventInvokeConfig operation: The function arn:aws:lambda:ap-southeast-2:123456789:function:hello:live doesn't have an EventInvokeConfig

[ojongerius]

@davidgf have a moment to review?

[ojongerius]

@davidgf ping! :)