migrate ios: refactor detector init and image orientation

Author: davidgovea

ios/RN/BarcodeDetectorManagerMlkit.m

@@ -5,7 +5,6 @@
 
 @interface BarcodeDetectorManagerMlkit ()
 @property(nonatomic, strong) MLKBarcodeScanner *barcodeRecognizer;
-@property(nonatomic, strong) MLK *vision;
 @property(nonatomic, assign) MLKBarcodeFormat setOption;
 @property(nonatomic, assign) NSInteger detectionMode;
 @property(nonatomic, assign) float scaleX;
@@ -17,8 +16,7 @@ @implementation BarcodeDetectorManagerMlkit
 - (instancetype)init
 {
   if (self = [super init]) {
-    self.vision = [MLK vision];
-    self.barcodeRecognizer = [_vision barcodeDetector];
+    self.barcodeRecognizer = [MLKBarcodeScanner barcodeScanner];
   }
   return self;
 }
@@ -64,7 +62,7 @@ - (void)setType:(id)json queue:(dispatch_queue_t)sessionQueue
               [[MLKBarcodeScannerOptions alloc]
               initWithFormats: requestedValue];
               self.barcodeRecognizer =
-              [self.vision barcodeDetectorWithOptions:options];
+              [MLKBarcodeScanner barcodeScannerWithOptions:options]
           });
       }
   }
@@ -84,6 +82,7 @@ - (void)findBarcodesInFrame:(UIImage *)uiImage
     self.scaleX = scaleX;
     self.scaleY = scaleY;
     MLKVisionImage *image = [[MLKVisionImage alloc] initWithImage:uiImage];
+    image.orientation = uiImage.imageOrientation;
     NSMutableArray *emptyResult = [[NSMutableArray alloc] init];
     [_barcodeRecognizer processImage:image
         completion:^(NSArray<MLKBarcode *> *barcodes, NSError *error) {

ios/RN/FaceDetectorManagerMlkit.m

@@ -4,7 +4,6 @@
 
 @interface FaceDetectorManagerMlkit ()
 @property(nonatomic, strong) MLKFaceDetector *faceRecognizer;
-@property(nonatomic, strong) MLK *vision;
 @property(nonatomic, strong) MLKFaceDetectorOptions *options;
 @property(nonatomic, assign) float scaleX;
 @property(nonatomic, assign) float scaleY;
@@ -19,9 +18,8 @@ - (instancetype)init
     self.options.performanceMode = MLKFaceDetectorPerformanceModeFast;
     self.options.landmarkMode = MLKFaceDetectorLandmarkModeNone;
     self.options.classificationMode = MLKFaceDetectorClassificationModeNone;
-    
-    self.vision = [MLK vision];
-    self.faceRecognizer = [_vision faceDetectorWithOptions:_options];
+
+    self.faceRecognizer = [MLKFaceDetector faceDetectorWithOptions:options];
   }
   return self;
 }
@@ -57,7 +55,7 @@ - (void)setTracking:(id)json queue:(dispatch_queue_t)sessionQueue
           dispatch_async(sessionQueue, ^{
               self.options.trackingEnabled = requestedValue;
               self.faceRecognizer =
-              [self.vision faceDetectorWithOptions:self.options];
+              [MLKFaceDetector faceDetectorWithOptions:self.options];
           });
       }
   }
@@ -71,7 +69,7 @@ - (void)setLandmarksMode:(id)json queue:(dispatch_queue_t)sessionQueue
             dispatch_async(sessionQueue, ^{
                 self.options.landmarkMode = requestedValue;
                 self.faceRecognizer =
-                [self.vision faceDetectorWithOptions:self.options];
+                [MLKFaceDetector faceDetectorWithOptions:self.options];
             });
         }
     }
@@ -85,7 +83,7 @@ - (void)setPerformanceMode:(id)json queue:(dispatch_queue_t)sessionQueue
             dispatch_async(sessionQueue, ^{
                 self.options.performanceMode = requestedValue;
                 self.faceRecognizer =
-                [self.vision faceDetectorWithOptions:self.options];
+                [MLKFaceDetector faceDetectorWithOptions:self.options];
             });
         }
     }

ios/RN/TextDetectorManager.m

@@ -12,8 +12,8 @@ @implementation TextDetectorManager
 - (instancetype)init
 {
   if (self = [super init]) {
-    MLK *vision = [MLK vision];
-    self.textRecognizer = [vision onDeviceTextRecognizer];
+    self.textRecognizer = [MLKTextRecognizer textRecognizer];
+
   }
   return self;
 }
@@ -28,6 +28,7 @@ - (void)findTextBlocksInFrame:(UIImage *)uiImage scaleX:(float)scaleX scaleY:(fl
     self.scaleX = scaleX;
     self.scaleY = scaleY;
     MLKVisionImage *image = [[MLKVisionImage alloc] initWithImage:uiImage];
+    image.orientation = uiImage.imageOrientation;
     NSMutableArray *textBlocks = [[NSMutableArray alloc] init];
     [_textRecognizer processImage:image
                        completion:^(MLKText *_Nullable result,