-
-
Notifications
You must be signed in to change notification settings - Fork 974
V6 #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davidjbradshaw
wants to merge
733
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V6 #1570
Changes from all commits
Commits
Show all changes
733 commits
Select commit
Hold shift + click to select a range
3d65919
PR fixes
davidjbradshaw 617a815
Fix solid tests"
davidjbradshaw 6862310
Add support for Alpine.js
davidjbradshaw 76a147e
PR feedback on Alpine
davidjbradshaw 9656078
Update MIGRATION_SUMMARY.md
davidjbradshaw e43eff7
Drop Vue 2 support
davidjbradshaw aac4147
PR feedback Vue3.3
davidjbradshaw b89cba9
refactor(vue): derive IframeResizerMethods from IFrameObject in core
davidjbradshaw 9023be3
Vue example package lock
davidjbradshaw 0c311ed
Fix Alpine directive options evaluation and update event data display
davidjbradshaw 43ea748
Merge branch 'dev' into dev-alpine
davidjbradshaw ebc43b6
Add event and direction to onBeforeResize()
davidjbradshaw 50f021f
Update typing
davidjbradshaw 2c32938
refactor: derive union types from consts across packages
davidjbradshaw 016ab2a
Add event and direction to onBeforeResize()
davidjbradshaw 7810f51
Update typing
davidjbradshaw a0b69a3
Merge branch 'dev' into refactor/const-union-types
davidjbradshaw 2be8a4c
Change LogOption type from -1 to number
davidjbradshaw 50ace3d
tidy
davidjbradshaw d3bed9a
Tidy
davidjbradshaw 2843907
Merge pull request #1652 from davidjbradshaw/refactor/const-union-types
davidjbradshaw 33e722c
Initial plan: investigate and confirm failing Jasmine tests
Copilot 178f1ff
Changes before error encountered
Copilot edf272d
Fix intermittent race conditions in Jasmine integration tests
Copilot e49f538
feat: add numeric shorthand for log option (0=disabled, 1=collapsed, …
davidjbradshaw ec2ea36
Update README for v6
davidjbradshaw f994314
fix: make manual-logging URL param checks explicit for all log levels
davidjbradshaw c2e0750
Remove disconnected iframes section from README
davidjbradshaw e4fe3cd
Update MIGRATION_SUMMARY.md
davidjbradshaw 188abb3
Merge branch 'dev' into dev-alpine
davidjbradshaw be764b4
Merge pull request #1649 from davidjbradshaw/dev-alpine
davidjbradshaw 9d242ef
Use ACG with Angular
davidjbradshaw 7e84a51
pr review
davidjbradshaw 9f7ffe3
Fix type safety for logExpand option in Angular directive
davidjbradshaw 92ab5f9
Merge branch 'dev' into feat/log-numeric-options
davidjbradshaw baffc52
Merge pull request #1653 from davidjbradshaw/feat/log-numeric-options
davidjbradshaw d540492
Extend linting to TS files and fix issues (#1660)
davidjbradshaw 3637c2a
Fix solid/index.ts: use export...from with no-restricted-exports disable
Copilot 1b4e48f
Merge branch 'master' into dev
davidjbradshaw 4c72bdc
Update packages/core/monitor/props.ts
davidjbradshaw 25203d9
Update packages/child/methods/parent-props.ts
davidjbradshaw 55bae6f
Guard getComputedStyle in decode.ts and fix solid/index.ts export pat…
Copilot cc02d33
Clarify information visit instruction in TEMPLATE.md
davidjbradshaw 6f925a7
Add test for null visualViewport branch in core/monitor/props.ts
Copilot 54b55b0
Add tests to close coverage gaps across multiple modules
Copilot 17e3ae5
Remove redundant cleanup in mutation throttle test
Copilot 62fd6a0
Update GitHub Actions to latest versions (checkout@v6, setup-node@v6,…
Copilot de8acd6
Tidy
davidjbradshaw 77111dd
fix tests
davidjbradshaw 6e157a1
Update packages/child/methods/parent-props.ts
davidjbradshaw 9836f61
fix more types
davidjbradshaw 6ebe4b0
Update packages/child/observers/overflow.ts
davidjbradshaw 2a8a8cf
Tidy Astro
davidjbradshaw cbe6e8b
Astro
davidjbradshaw ae3aebb
fix tests
davidjbradshaw c2f1a8f
More test
davidjbradshaw bbee1b2
pr review
davidjbradshaw 1759585
Fix more types
davidjbradshaw b248947
Add typechecking to `npm test`
davidjbradshaw 7cdcdf6
tidy
davidjbradshaw 0a8ddaf
Update build
davidjbradshaw 62aae31
Fix solid build issue
davidjbradshaw 43e13e3
yet another unit test
davidjbradshaw 0f4c80d
PR review
davidjbradshaw 0b2e339
Use `getPropValue()`
davidjbradshaw 73f6c17
Add support for `targetOrigin` array in child
davidjbradshaw 1637502
Add support for targetOrigin array in child
davidjbradshaw dd3deb0
Fix overflowObserver check in Safari 16 and below.
davidjbradshaw d97f83e
Fix resize failure after forced content scrolling
davidjbradshaw 11c4f05
PR review
davidjbradshaw 5a3dbd7
Remove legacy package
davidjbradshaw 17239b8
Remove legacy build entries from vite.config.js, build/pkgJson.js, an…
Copilot 2b121f8
Update packages/child/index.ts
davidjbradshaw 766d757
Stop version double firing in build script
davidjbradshaw 6641e2e
ditto
davidjbradshaw cf5fe66
delint
davidjbradshaw 1e59eb4
Remove v5 deprecations
davidjbradshaw 573f580
Update build banner
davidjbradshaw ed4efc5
Further removal of deprecated v4 APIs
davidjbradshaw ba32f8c
fix: update parentIFrame to parentIframe in types.ts JSDoc comments
Copilot 41096ee
Remove more old code
davidjbradshaw 091f5cf
Fix test
davidjbradshaw 1cea2c2
Fix test
davidjbradshaw 363947f
Remove v5 deprecations
davidjbradshaw 110d052
Update build banner
davidjbradshaw 6a63ce6
Further removal of deprecated v4 APIs
davidjbradshaw 3752707
fix: update parentIFrame to parentIframe in types.ts JSDoc comments
Copilot eabba82
Remove more old code
davidjbradshaw af044b7
Fix test
davidjbradshaw caf9760
Fix test
davidjbradshaw e36dc4f
Fix types
davidjbradshaw f5bc53d
Merge branch 'dev' into dev_types
davidjbradshaw 4053661
Fix test
davidjbradshaw 4953445
fix test
davidjbradshaw 0b75bcf
Standardize types across versions
davidjbradshaw 8e7e7bb
PR review
davidjbradshaw 74de300
Move adventures in type tidying
davidjbradshaw 66a98ce
Build types
davidjbradshaw 817d44a
More type fixen
davidjbradshaw 650482d
Fix type
davidjbradshaw 8880eb2
Fix filetype
davidjbradshaw e6bd9a6
Move parent to vite
davidjbradshaw 7b3511c
Child types
davidjbradshaw 5989ba6
Update types build
davidjbradshaw 6427b22
Make common it's own package
davidjbradshaw d115bc9
PR feedback
davidjbradshaw b696b41
fix build
davidjbradshaw 867479e
Fix type
davidjbradshaw 1d5c39b
fix: type iframes array and return type as IframeComponent[] in facto…
Copilot 2b05ff1
fix: cast to IframeComponent[] only at return, keep internal array as…
Copilot 62dfd8e
Tidy
davidjbradshaw 1921380
Fix build configs
davidjbradshaw e49a62b
Fix build type warning
davidjbradshaw 2e21b67
Publish common
davidjbradshaw e25aa43
Update common build
davidjbradshaw 3879813
fix build minification
davidjbradshaw 7b5b030
fix e2e
davidjbradshaw fcce42a
Update examples
davidjbradshaw 7bba755
Fix Playwright CI: use build:dev, remove js-dist copy step
davidjbradshaw 1760b6e
e2e
davidjbradshaw 7df15b4
Merge branch 'dev' into dev_types
davidjbradshaw 8520777
Fix Playwright CI: build all packages for example builds
davidjbradshaw 604225a
fix e2e
davidjbradshaw d1062f4
fix e2e
davidjbradshaw e524b6a
Add @iframe-resizer/common alias to example vite configs
davidjbradshaw 337efa8
Create js-dist symlink before example builds in CI
davidjbradshaw 883671d
Trigger CI rebuild
davidjbradshaw 3c47999
Add comment to Playwright workflow
davidjbradshaw 24422f3
Merge branch 'dev' into dev_types
davidjbradshaw 8b828a3
e2e
davidjbradshaw 394c9c1
e2e
davidjbradshaw 281ddb8
Split consts from common
davidjbradshaw 1425aa7
Update examples post publish
davidjbradshaw 18b2c1e
vscode
davidjbradshaw cce69cf
update examples
davidjbradshaw 5067e35
v6.0.0-beta-9
davidjbradshaw 0999dbc
fix action
davidjbradshaw 8bc8f7e
fix action
davidjbradshaw 35f038d
.
davidjbradshaw 4fdeb1d
.
davidjbradshaw 86ed579
Update example/html/child/frame.content.html
davidjbradshaw 8f1d094
Add deprecated x/y aliases to IframeScrollData type
Copilot b1ec421
update publish
davidjbradshaw de0262e
pr review
davidjbradshaw e30c705
update examples
davidjbradshaw ea6480f
add fav icon
davidjbradshaw 059f40a
tidy
davidjbradshaw 9c06129
iFrame -> iFrame
davidjbradshaw 09f1e33
Fix solid wrapper
davidjbradshaw cdd0e8b
update eslint
davidjbradshaw 152ca12
combine example child
davidjbradshaw b96e991
Merge pull request #1670 from davidjbradshaw/dev_types
davidjbradshaw 287e34f
More adventures in typing
davidjbradshaw daecdaa
better type on parent
davidjbradshaw c66465f
types
davidjbradshaw b8cd344
Fix more missing more types
davidjbradshaw 4508b83
Update build scripts
davidjbradshaw 6986992
fix test
davidjbradshaw e05e7f8
Merge pull request #1673 from davidjbradshaw/dev-build
davidjbradshaw 5fbaf4e
Update mocks to use @iframe-resizer/common
davidjbradshaw 722c56f
warn if moveToAnchor warning
davidjbradshaw 4a87b04
Review feedback
davidjbradshaw 8dffbb3
fixes
davidjbradshaw 5b71d40
Fix tests
davidjbradshaw 066040a
Merge pull request #1674 from davidjbradshaw/dev-report
davidjbradshaw 41b9932
build dts
davidjbradshaw a945e4a
.
davidjbradshaw 7b75d6b
build dts fix
davidjbradshaw 58a7053
IFrame.d.ts
davidjbradshaw 882b79a
Simplefy type export
davidjbradshaw 37a6242
delint
davidjbradshaw fae3524
Fix sfc build
davidjbradshaw 61af480
playwrite
davidjbradshaw 8975ad8
pr feedback
davidjbradshaw ee66d30
pr feedback
davidjbradshaw 2fecf2e
expand e2e tests
davidjbradshaw 547c93c
fixes
davidjbradshaw 71929cf
pr fixes
davidjbradshaw f10d832
delint
davidjbradshaw 423dee3
fix
davidjbradshaw 94a1b13
Fix e2e Angular
davidjbradshaw 77c7e2b
fix angular e2e
davidjbradshaw bd363f7
Fix e2e
davidjbradshaw b5e9029
Tidy React
davidjbradshaw 0617f0d
Deprecate `waitForLoad`
davidjbradshaw 9a8be0f
Remove dead code
davidjbradshaw 8bdf1f5
Add `getVersion()` child
davidjbradshaw 07e2579
Add type
davidjbradshaw 90e7c09
Fix flacky test
davidjbradshaw 2a69998
Add `getVersion()` parent
davidjbradshaw b174e2b
PR feedback
davidjbradshaw 5764d6b
Fix tests
davidjbradshaw 38fb131
typo
davidjbradshaw 27b17cc
typo
davidjbradshaw 8c3e8cc
Typo
davidjbradshaw 27b94c6
tidy
davidjbradshaw 1625495
PR fix
davidjbradshaw f1ecaf6
SemVar type
davidjbradshaw ef6a96e
fix types
davidjbradshaw 6249be0
Sort React refs
davidjbradshaw 317486c
Add test moveToAnchor
davidjbradshaw ea47712
Refactor common utils
davidjbradshaw 85756af
Refactor package.json
davidjbradshaw 23370f9
fix action
davidjbradshaw 8133465
Tidy Workflow
davidjbradshaw 92ff9b3
Remove redundent codeQL action
davidjbradshaw 90aeaaa
update funding
davidjbradshaw 2a31774
PR review
davidjbradshaw 49984c8
Try sameOrigin on first message to child
davidjbradshaw d6b6744
Update for V6
davidjbradshaw 52e89f3
V6.0.0
davidjbradshaw d8bbe54
v6.0.0
davidjbradshaw 06059e5
Add web-component
davidjbradshaw ac0dfa8
Fix race condition
davidjbradshaw 61ceaab
Packages review"
davidjbradshaw 00f4913
Fix acg setup
davidjbradshaw de8abfb
Packages review"
davidjbradshaw 6ae1742
Fix acg setup
davidjbradshaw 9f569a9
new tests
davidjbradshaw 7e462b1
Update build wc iife
davidjbradshaw 08b9156
Web Component example
davidjbradshaw 4b3d152
PR review
davidjbradshaw 1959289
wc example styles
davidjbradshaw c748348
PR review
davidjbradshaw 9752690
filter attr
davidjbradshaw 8811728
Tidy
davidjbradshaw dd4ed82
Fix SSR WC
davidjbradshaw ec3b14d
Guard against duplicate iframes if element is moved in the DOM
davidjbradshaw 7eb862c
PR review
davidjbradshaw 71d69bd
Tidy
davidjbradshaw 24c80bd
Fix link
davidjbradshaw 7d8f7eb
Merge branch 'dev' into dev-review
davidjbradshaw 82a75e0
delint
davidjbradshaw 7781197
Test package update
davidjbradshaw bf9f6ad
Merge branch 'dev' into dev-review
davidjbradshaw 8f30a62
Merge pull request #1681 from davidjbradshaw/dev-review
davidjbradshaw 0d818cb
Improve formatting of LICENSE file
davidjbradshaw 23ab02a
Add pnpm installation instructions to TEMPLATE.md
davidjbradshaw 426a938
Update types
davidjbradshaw 30defa1
Add array support to WC
davidjbradshaw b81e5ff
PR feedback
davidjbradshaw 149e986
Merge branch 'dev' into dev-review
davidjbradshaw 15c9600
Merge pull request #1682 from davidjbradshaw/dev-review
davidjbradshaw 67199ed
refactor core router
davidjbradshaw 42cf9ef
update readme
davidjbradshaw 70fb663
deprecate old types
davidjbradshaw 5b513a6
Fix type prefixes
davidjbradshaw 23a2b3d
Extract types from tsx files
davidjbradshaw af37a2d
`data-iframe-size` -> `data-iframe-resize`
davidjbradshaw 765f25c
Fix flaky license validation tests under random order
davidjbradshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # GitHub Copilot Instructions | ||
|
|
||
| ## Before every commit/check-in | ||
|
|
||
| **Always run `npm run eslint:fix` before committing any changes.** | ||
|
|
||
| This is mandatory — failure to run `eslint:fix` will cause CI to fail with ESLint formatting and style errors. | ||
|
|
||
| ```bash | ||
| npm run eslint:fix # Lint and auto-fix all issues | ||
| npm run eslint # Lint only (to verify) | ||
| ``` | ||
|
|
||
| See `CLAUDE.md` for full project guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow grants broad write permissions to
GITHUB_TOKEN. If the job only needs to comment (or only on certain events), reduce permissions to the minimum required (principle of least privilege), and consider elevating permissions only for the specific steps that require them.