Fix manual resize requests to always dispatch messages#1586
Conversation
Co-authored-by: davidjbradshaw <591634+davidjbradshaw@users.noreply.github.com>
…_RESIZE_REQUEST in getContentSize Co-authored-by: davidjbradshaw <591634+davidjbradshaw@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot The test is still failing for a different reason. The problem is we are running the tests too fast, we need to wait for the animation frame to clear before running this, to avoid the throttle. |
Co-authored-by: davidjbradshaw <591634+davidjbradshaw@users.noreply.github.com>
... Fixed in commit c5f7188. The issue was that the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot would it make more sense to to add |
No, |
The
setTargetOriginintegration test was failing because manual resize requests were being ignored when dimensions hadn't changed. Additionally, theresize(rightMostElement)test was failing because parent-initiated resize requests were being throttled.Changes
packages/child/size/content.js: AddedMANUAL_RESIZE_REQUESTandPARENT_RESIZE_REQUESTto the switch cases that force message dispatch, ensuringresize()and parent-initiated resizes always send messages regardless of size deltapackages/child/send/size.js: Modified thesendPendingthrottle check to exclude manual and parent resize requests, allowing them to bypass the pending check similar toOVERFLOW_OBSERVERContext
The issues were:
getContentSize()returnednullfor unchanged sizes, preventingdispatch()from being calledsendPendingthrottle blocked parent-initiated resize requests when another resize was already queuedManual and parent resize requests must always be processed immediately, even when dimensions are identical or another resize is pending.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.