Refactor React#1684
Draft
davidjbradshaw wants to merge 4 commits into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the @iframe-resizer/react wrapper by extracting the iframe-resizer setup/teardown and forwarded-ref imperative API wiring into two dedicated React hooks, simplifying the main component implementation.
Changes:
- Extracted iframe-resizer initialization/logging/cleanup into
useResizer. - Extracted
forwardRefimperative handle wiring intouseForwardedRef. - Reduced
packages/react/index.tsxto a small component that composes the hooks and renders the<iframe>.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react/index.tsx | Replaced inline effect + imperative handle logic with hook composition. |
| packages/react/use-resizer.ts | New hook encapsulating resizer setup, logging group initialization, and cleanup. |
| packages/react/use-forwarded-ref.ts | New hook encapsulating useImperativeHandle methods exposed via forwarded ref. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
davidjbradshaw
marked this pull request as draft
June 18, 2026 11:19
| getIframeResizer().sendMessage(message, targetOrigin) | ||
| }, | ||
| }), | ||
| [iframeRef], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.