Skip to content

Commit 93f1e68

Browse files
committed
Update BarcodeDetector tests to only skip if known issue is detected
1 parent 28c98a6 commit 93f1e68

1 file changed

Lines changed: 28 additions & 8 deletions

File tree

src/BarcodeDetector.browser.test.mjs

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,40 @@ it(
2424
mode.numeric('123'),
2525
),
2626
},
27-
28-
// Temporarily disabling these as they fail to read on Chrome on M-series macs
29-
// See https://issues.chromium.org/issues/384033047
30-
//{ name: 'iso8859-1', message: 'ISO8859-1-compatible characters \u00A31.00' },
31-
//{ name: 'shift-jis', message: 'Kanji characters \u6F22\u5B57' },
32-
//{ name: 'mixed iso8859-1 and utf8', message: 'iso8859 \u00A3\u00A3\u00A3\u00A3\u00A3 then utf8 \u2026' },
27+
{
28+
name: 'iso8859-1',
29+
message: 'ISO8859-1-compatible characters \u00A31.00',
30+
knownARMFail: true,
31+
},
32+
{
33+
name: 'shift-jis',
34+
message: 'Kanji characters \u6F22\u5B57',
35+
knownARMFail: true,
36+
},
37+
{
38+
name: 'mixed iso8859-1 and utf8',
39+
message: 'iso8859 \u00A3\u00A3\u00A3\u00A3\u00A3 then utf8 \u2026',
40+
knownARMFail: true,
41+
},
3342
],
3443
},
35-
async ({ message, expected = message, encoded = message }) => {
44+
async ({
45+
message,
46+
expected = message,
47+
encoded = message,
48+
knownARMFail = false,
49+
}) => {
3650
const code = generate(encoded);
3751
const image = code.toImageData(VIRTUAL_CANVAS, IMAGE_OPTIONS);
3852
const detector = new BarcodeDetector({ formats: ['qr_code'] });
3953
const detected = await detector.detect(image);
4054
expect(detected).hasLength(1);
41-
expect(detected[0].rawValue).equals(expected);
55+
const detectedValue = detected[0].rawValue;
56+
if (detectedValue === '' && knownARMFail) {
57+
skip(
58+
'known M-series Mac issue: https://issues.chromium.org/issues/384033047',
59+
);
60+
}
61+
expect(detectedValue).equals(expected);
4262
},
4363
);

0 commit comments

Comments
 (0)