Add support for useLayoutEffect via exec.layout API#32
Open
chaance wants to merge 2 commits intodavidkpiano:masterfrom
Open
Add support for useLayoutEffect via exec.layout API#32chaance wants to merge 2 commits intodavidkpiano:masterfrom
useLayoutEffect via exec.layout API#32chaance wants to merge 2 commits intodavidkpiano:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an API for calling certain effects with
useLayoutEffect. This should probably be used very carefully and rarely, but in certain cases it is useful.API should be identical to calling
execdirectly.I didn't add documentation yet but am happy to contribute there as well in a follow-up unless someone beats me to it.
Should be pretty straight forward, though the types are getting a bit verbose so let me know if you have any questions!