Merge pull request #68 from davidmyersdev/fix-import-globals-with-trailing-slash

Fix import globals with trailing slash

Author: davidmyersdev

.github/workflows/ci.yml

@@ -28,7 +28,6 @@ jobs:
       - uses: ./.github/actions/install-dependencies
       - run: pnpm build:core
       - run: pnpm build:shims
-      - run: pnpm build:banner
       - run: pnpm playwright install --with-deps
       - run: pnpm -r test
   test-unit:
@@ -40,7 +39,6 @@ jobs:
       - uses: ./.github/actions/install-dependencies
       - run: pnpm build:core
       - run: pnpm build:shims
-      - run: pnpm build:banner
       - run: pnpm test:build
   typecheck:
     needs:
@@ -51,5 +49,4 @@ jobs:
       - uses: ./.github/actions/install-dependencies
       - run: pnpm build:core
       - run: pnpm build:shims
-      - run: pnpm build:banner
       - run: pnpm typecheck

examples/vanilla/package.json

@@ -5,8 +5,8 @@
     "build": "vite build",
     "dev": "vite",
     "test": "CI=true run-p test:build test:dev",
-    "test:build": "VITE_COMMAND=build WEB_SERVER_COMMAND='vite build && vite preview --port 5174' WEB_SERVER_URL='http://localhost:5174' playwright test",
-    "test:dev": "VITE_COMMAND=dev WEB_SERVER_COMMAND='vite dev' WEB_SERVER_URL='http://localhost:5173' playwright test",
+    "test:build": "VITE_COMMAND=build WEB_SERVER_COMMAND='vite build && vite preview --port 15174' WEB_SERVER_URL='http://localhost:15174' playwright test",
+    "test:dev": "VITE_COMMAND=dev WEB_SERVER_COMMAND='vite dev --port 15173' WEB_SERVER_URL='http://localhost:15173' playwright test",
     "typecheck": "tsc"
   },
   "devDependencies": {

examples/vanilla/src/main.ts

@@ -14,8 +14,11 @@ const something = {
   },
 }
 
+class Symbol {}
+
 fs.writeFileSync('./test.txt', 'Hello from fs!', 'utf-8')
 
+console.log(Symbol)
 console.log(fs)
 console.log(fetch)
 console.log(resolve('.'))

examples/vanilla/test/e2e/main.spec.ts

@@ -25,6 +25,7 @@ test('logs the correct values', async ({ page }) => {
 
   if (isBuild) {
     expect(logs).toEqual([
+      'class Symbol {\n    }',
       '{Volume: , vol: Volume, createFsFromVolume: , fs: Object, memfs: }',
       'function fetch() { [native code] }',
       '/',
@@ -43,6 +44,7 @@ test('logs the correct values', async ({ page }) => {
     expect(logs).toEqual([
       '[vite] connecting...',
       '[vite] connected.',
+      'class Symbol {\n}',
       '{Volume: , vol: _Volume, createFsFromVolume: , fs: Object, memfs: }',
       'function fetch() { [native code] }',
       '/',

package.json

@@ -31,21 +31,29 @@
       "require": "./shims/dist/index.cjs",
       "import": "./shims/dist/index.js"
     },
-    "./shims/banner": {
-      "require": "./shims/banner/dist/index.cjs",
-      "import": "./shims/banner/dist/index.js"
-    },
     "./shims/buffer": {
       "require": "./shims/buffer/dist/index.cjs",
       "import": "./shims/buffer/dist/index.js"
     },
+    "./shims/buffer/": {
+      "require": "./shims/buffer/dist/index.cjs",
+      "import": "./shims/buffer/dist/index.js"
+    },
     "./shims/global": {
       "require": "./shims/global/dist/index.cjs",
       "import": "./shims/global/dist/index.js"
     },
+    "./shims/global/": {
+      "require": "./shims/global/dist/index.cjs",
+      "import": "./shims/global/dist/index.js"
+    },
     "./shims/process": {
       "require": "./shims/process/dist/index.cjs",
       "import": "./shims/process/dist/index.js"
+    },
+    "./shims/process/": {
+      "require": "./shims/process/dist/index.cjs",
+      "import": "./shims/process/dist/index.js"
     }
   },
   "main": "./dist/index.cjs",
@@ -56,8 +64,7 @@
     "shims"
   ],
   "scripts": {
-    "build": "run-s build:core build:shims build:banner build:types",
-    "build:banner": "vite-node ./shims/banner/build.ts",
+    "build": "run-s build:core build:shims build:types",
     "build:core": "vite build",
     "build:shims": "run-p build:shims:*",
     "build:shims:buffer": "vite build -c ./shims/vite.config.ts ./shims/buffer",
@@ -66,14 +73,15 @@
     "build:types": "run-s typecheck",
     "lint": "eslint .",
     "lint:fix": "eslint --fix .",
-    "test": "run-s test:build",
+    "test": "run-p test:build test:unit",
     "test:build": "run-p test:build:*",
     "test:build:react": "pnpm -C ./examples/react run build",
     "test:build:vanilla": "pnpm -C ./examples/vanilla run build",
     "test:build:vue": "pnpm -C ./examples/vue run build",
     "test:dev:react": "pnpm -C ./examples/react run dev",
     "test:dev:vanilla": "pnpm -C ./examples/vanilla run dev",
     "test:dev:vue": "pnpm -C ./examples/vue run dev",
+    "test:unit": "vitest run --dir ./test",
     "typecheck": "run-p typecheck:*",
     "typecheck:core": "tsc",
     "typecheck:react": "pnpm -C ./examples/react run typecheck",
@@ -102,7 +110,8 @@
     "vite-node": "^0.34.6",
     "vite-plugin-externalize-deps": "^0.1.5",
     "vite-plugin-inspect": "^0.7.42",
-    "vite-plugin-node-polyfills": "workspace:*"
+    "vite-plugin-node-polyfills": "workspace:*",
+    "vitest": "^1.1.0"
   },
   "publishConfig": {
     "access": "public"