fix: use oxc instead of esbuild when Rolldown is detected#154
Open
zymotik wants to merge 1 commit intodavidmyersdev:mainfrom
Open
fix: use oxc instead of esbuild when Rolldown is detected#154zymotik wants to merge 1 commit intodavidmyersdev:mainfrom
zymotik wants to merge 1 commit intodavidmyersdev:mainfrom
Conversation
Vite 8 dropped esbuild in favor of oxc for JS transforms. The plugin was still setting `esbuild.banner` unconditionally, which triggers a deprecation warning on Vite 8. This uses the existing `isRolldownVite` check to pick between `oxc.jsxInject` and `esbuild.banner` for dev banner injection, matching how `optimizeDeps` already branches between rolldownOptions and esbuildOptions. Also adds ^8.0.0 to peerDependencies. Closes davidmyersdev#142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildoption was specified by "vite-plugin-node-polyfills" plugin. This option is deprecated, please useoxcinstead #142Context
Issue #142 references this exact commit by @yeboster, and this PR ports it into the upstream repository.