Skip to content

Commit 11a77db

Browse files
committed
slight restructuring of update_resource estimates in pipeline runner
1 parent 0d0558a commit 11a77db

1 file changed

Lines changed: 17 additions & 8 deletions

File tree

MC/bin/o2_dpg_workflow_runner.py

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -426,15 +426,24 @@ def update_resource_estimates(workflow, resource_json):
426426

427427
new_resources = resource_dict[name]
428428

429-
task["resources"]["mem"] = new_resources.get("mem", task["resources"]["mem"])
429+
oldmem = task["resources"]["mem"]
430+
newmem = new_resources.get("mem", task["resources"]["mem"])
431+
actionlogger.info("Updating mem estimate for " + task["name"] + " from " + str(oldmem) + " to " + str(newmem))
432+
task["resources"]["mem"] = newmem
433+
# should we really be correcting for relative_cpu, when we have an outer estimate ??
434+
oldcpu = task["resources"]["cpu"]
435+
newcpu = new_resources.get("cpu", task["resources"]["cpu"])
436+
actionlogger.info("Updating cpu estimate for " + task["name"] + " from " + str(oldcpu) + " to " + str(newcpu))
437+
task["resources"]["cpu"] = newcpu
438+
430439
# CPU is a bit more invlolved
431-
if "cpu" in new_resources:
432-
cpu = new_resources["cpu"]
433-
rel_cpu = task["resources"]["relative_cpu"]
434-
if rel_cpu is not None:
435-
# respect the relative CPU settings
436-
cpu *= rel_cpu
437-
task["resources"]["cpu"] = cpu
440+
# if "cpu" in new_resources:
441+
# cpu = new_resources["cpu"]
442+
# rel_cpu = task["resources"]["relative_cpu"]
443+
# if rel_cpu is not None:
444+
# # respect the relative CPU settings
445+
# cpu *= rel_cpu
446+
# task["resources"]["cpu"] = cpu
438447

439448
#
440449
# functions for execution; encapsulated in a WorkflowExecutor class

0 commit comments

Comments
 (0)