-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtoken-validation.test.ts
More file actions
468 lines (412 loc) · 14.2 KB
/
token-validation.test.ts
File metadata and controls
468 lines (412 loc) · 14.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
/**
* Token validation integration tests
*
* Tests token validation during initialization with validation_endpoint
*/
import { describe, it, expect, beforeAll, afterAll } from 'vitest';
import request from 'supertest';
import { HttpTransport } from '../transport/http-transport.js';
import { ConsoleLogger } from '../core/logger.js';
import type { Express } from 'express';
import type { AuthInterceptor } from '../types/profile.js';
import http from 'http';
import { describeIfListen } from './listen-support.js';
describeIfListen('Token Validation Integration', () => {
let transport: HttpTransport;
let app: Express;
let mockApiServer: http.Server;
let mockApiPort: number;
let validationCallCount = 0;
let lastValidationToken: string | undefined;
let originalAllowPrivateNetwork: string | undefined;
beforeAll(async () => {
originalAllowPrivateNetwork = process.env.MCP4_SSRF_ALLOW_PRIVATE_NETWORK;
process.env.MCP4_SSRF_ALLOW_PRIVATE_NETWORK = 'true';
// Setup mock API server for validation endpoint
const mockApp = (await import('express')).default();
mockApp.use((await import('express')).default.json());
// Mock validation endpoint: /api/v4/personal_access_tokens/self
mockApp.get('/api/v4/personal_access_tokens/self', (req, res) => {
validationCallCount++;
const authHeader = req.headers.authorization;
lastValidationToken = authHeader?.replace('Bearer ', '');
if (!authHeader) {
return res.status(401).json({ message: 'Unauthorized' });
}
const token = authHeader.replace('Bearer ', '');
// Valid tokens start with "valid-"
if (token.startsWith('valid-')) {
return res.status(200).json({
id: 123,
name: 'test-token',
active: true,
scopes: ['read_api'],
expires_at: '2025-12-31',
});
}
// Invalid tokens
return res.status(401).json({ message: 'Unauthorized' });
});
// Mock validation endpoint: /api/v4/version (no auth required)
mockApp.get('/api/v4/version', (req, res) => {
validationCallCount++;
return res.status(200).json({
version: '16.5.0',
revision: 'abc123',
});
});
// Mock validation endpoint: /api/v4/projects (requires auth)
mockApp.get('/api/v4/projects', (req, res) => {
validationCallCount++;
const authHeader = req.headers.authorization;
lastValidationToken = authHeader?.replace('Bearer ', '');
if (!authHeader) {
return res.status(401).json({ message: 'Unauthorized' });
}
const token = authHeader.replace('Bearer ', '');
if (token.startsWith('valid-')) {
return res.status(200).json([]);
}
return res.status(401).json({ message: 'Unauthorized' });
});
// Start mock API server
mockApiServer = mockApp.listen(0);
const address = mockApiServer.address();
mockApiPort = typeof address === 'object' && address ? address.port : 0;
// Auth configs with validation
const authConfigs: AuthInterceptor[] = [
{
type: 'bearer',
priority: 0,
value_from_env: 'MCP4_API_TOKEN',
validation_endpoint: '/api/v4/personal_access_tokens/self',
},
];
const config = {
host: '127.0.0.1',
port: 0,
sessionTimeoutMs: 1800000,
heartbeatEnabled: false,
heartbeatIntervalMs: 30000,
metricsEnabled: false,
metricsPath: '/metrics',
baseUrl: `http://127.0.0.1:${mockApiPort}`,
authConfigs,
};
const logger = new ConsoleLogger();
transport = new HttpTransport(config, logger);
app = (transport as any).app;
// Set up mock message handler
transport.setMessageHandler(async (message: unknown) => {
const msg = message as any;
if (msg.method === 'initialize') {
return {
jsonrpc: '2.0',
id: msg.id,
result: {
protocolVersion: '2025-03-26',
serverInfo: {
name: 'test-server',
version: '1.0.0',
},
capabilities: {
tools: {},
},
},
};
}
if (msg.method === 'tools/list') {
return {
jsonrpc: '2.0',
id: msg.id,
result: {
tools: [],
},
};
}
return {
jsonrpc: '2.0',
id: msg.id,
error: {
code: -32601,
message: 'Method not found',
},
};
});
});
afterAll(() => {
mockApiServer.close();
if (originalAllowPrivateNetwork === undefined) {
delete process.env.MCP4_SSRF_ALLOW_PRIVATE_NETWORK;
} else {
process.env.MCP4_SSRF_ALLOW_PRIVATE_NETWORK = originalAllowPrivateNetwork;
}
});
describe('Valid Token', () => {
it('should accept valid token after successful validation', async () => {
validationCallCount = 0;
const response = await request(app)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer valid-token-123')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
// Validation should have been called
expect(validationCallCount).toBe(1);
expect(lastValidationToken).toBe('valid-token-123');
// Should create session
expect(response.headers['mcp-session-id']).toBeDefined();
expect(response.body.result).toBeDefined();
});
it('should not validate on subsequent requests with session', async () => {
validationCallCount = 0;
// First request - initialize with validation
const initResponse = await request(app)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer valid-token-456')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
expect(validationCallCount).toBe(1);
const sessionId = initResponse.headers['mcp-session-id'];
// Second request - with session, no validation
validationCallCount = 0;
await request(app)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Mcp-Session-Id', sessionId)
.send({
jsonrpc: '2.0',
id: 2,
method: 'tools/list',
params: {},
})
.expect(200);
// No validation on subsequent request
expect(validationCallCount).toBe(0);
});
});
describe('Invalid Token', () => {
it('should reject invalid token after failed validation', async () => {
validationCallCount = 0;
const response = await request(app)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer invalid-token-xyz')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
// Validation should have been called
expect(validationCallCount).toBe(1);
expect(lastValidationToken).toBe('invalid-token-xyz');
// Should not create session
expect(response.headers['mcp-session-id']).toBeUndefined();
// JSON-RPC error response (HTTP 200 to avoid triggering OAuth flow in clients)
expect(response.body.error).toBeDefined();
expect(response.body.error.message).toContain('invalid or expired');
});
it('should reject expired token', async () => {
validationCallCount = 0;
const response = await request(app)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer expired-token')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
expect(validationCallCount).toBe(1);
// JSON-RPC error response (HTTP 200 to avoid triggering OAuth flow in clients)
expect(response.body.error).toBeDefined();
expect(response.body.error.message).toContain('invalid or expired');
});
});
describe('Validation Endpoint Errors', () => {
it('should handle validation endpoint timeout', async () => {
// Create transport with very short timeout
const shortTimeoutAuthConfigs: AuthInterceptor[] = [
{
type: 'bearer',
value_from_env: 'MCP4_API_TOKEN',
validation_endpoint: '/api/v4/slow-endpoint', // Non-existent = timeout
validation_timeout_ms: 100, // Very short
},
];
const config = {
host: '127.0.0.1',
port: 0,
sessionTimeoutMs: 1800000,
heartbeatEnabled: false,
heartbeatIntervalMs: 30000,
metricsEnabled: false,
metricsPath: '/metrics',
baseUrl: `http://127.0.0.1:${mockApiPort}`,
authConfigs: shortTimeoutAuthConfigs,
};
const logger = new ConsoleLogger();
const timeoutTransport = new HttpTransport(config, logger);
const timeoutApp = (timeoutTransport as any).app;
timeoutTransport.setMessageHandler(async (message: unknown) => {
const msg = message as any;
if (msg.method === 'initialize') {
return {
jsonrpc: '2.0',
id: msg.id,
result: {
protocolVersion: '2025-03-26',
serverInfo: { name: 'test', version: '1.0.0' },
capabilities: { tools: {} },
},
};
}
return { jsonrpc: '2.0', id: msg.id, error: { code: -32601, message: 'Not found' } };
});
const response = await request(timeoutApp)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer valid-token-timeout')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
// JSON-RPC error response (HTTP 200 to avoid triggering OAuth flow in clients)
expect(response.body.error).toBeDefined();
expect(response.body.error.message).toContain('invalid or expired');
});
});
describe('No Validation Endpoint', () => {
it('should skip validation if validation_endpoint not configured', async () => {
// Create transport without validation endpoint
const noValidationAuthConfigs: AuthInterceptor[] = [
{
type: 'bearer',
value_from_env: 'MCP4_API_TOKEN',
// No validation_endpoint
},
];
const config = {
host: '127.0.0.1',
port: 0,
sessionTimeoutMs: 1800000,
heartbeatEnabled: false,
heartbeatIntervalMs: 30000,
metricsEnabled: false,
metricsPath: '/metrics',
baseUrl: `http://127.0.0.1:${mockApiPort}`,
authConfigs: noValidationAuthConfigs,
};
const logger = new ConsoleLogger();
const noValidationTransport = new HttpTransport(config, logger);
const noValidationApp = (noValidationTransport as any).app;
noValidationTransport.setMessageHandler(async (message: unknown) => {
const msg = message as any;
if (msg.method === 'initialize') {
return {
jsonrpc: '2.0',
id: msg.id,
result: {
protocolVersion: '2025-03-26',
serverInfo: { name: 'test', version: '1.0.0' },
capabilities: { tools: {} },
},
};
}
return { jsonrpc: '2.0', id: msg.id, error: { code: -32601, message: 'Not found' } };
});
validationCallCount = 0;
const response = await request(noValidationApp)
.post('/mcp')
.set('Accept', 'application/json')
.set('Content-Type', 'application/json')
.set('Authorization', 'Bearer any-token-works')
.send({
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: {
protocolVersion: '2025-03-26',
capabilities: {},
clientInfo: { name: 'test', version: '1.0.0' },
},
})
.expect(200);
// No validation should have been called
expect(validationCallCount).toBe(0);
expect(response.headers['mcp-session-id']).toBeDefined();
});
});
describe('Different Auth Types', () => {
it('should validate query parameter auth', async () => {
const queryAuthConfigs: AuthInterceptor[] = [
{
type: 'query',
query_param: 'api_key',
value_from_env: 'API_KEY',
validation_endpoint: '/api/v4/projects',
},
];
// Note: Query param validation would need mock API to support it
// This test verifies the code path exists
expect(queryAuthConfigs[0].validation_endpoint).toBeDefined();
});
it('should validate custom header auth', async () => {
const customHeaderAuthConfigs: AuthInterceptor[] = [
{
type: 'custom-header',
header_name: 'X-API-Key',
value_from_env: 'API_KEY',
validation_endpoint: '/api/v4/projects',
},
];
// Note: Custom header validation would need mock API to support it
// This test verifies the code path exists
expect(customHeaderAuthConfigs[0].validation_endpoint).toBeDefined();
});
});
});