🛡️ Sentinel: [MEDIUM] Fix internal error leakage via JSON-RPC responses#239
🛡️ Sentinel: [MEDIUM] Fix internal error leakage via JSON-RPC responses#239davidruzicka wants to merge 1 commit into
Conversation
This commit fixes a vulnerability where `handleOtherRequest` in the MCP server would leak raw internal error details (like file paths or stack traces) directly to the client in JSON-RPC responses for methods like `prompts/get`, `resources/read`, and `completion/complete`. It resolves the issue by generating a unique correlation ID, securely logging the error server-side with that ID, and sending a sanitized, generic error message to the client using `this.formatErrorForClient(error, correlationId)`. This aligns these handlers with the secure error handling practice established in `.jules/sentinel.md`. Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The MCP server's
handleOtherRequestmethod was catching exceptions and returning the raw error message directly to the client in JSON-RPC responses for methods likeprompts/get,resources/read, andcompletion/complete.🎯 Impact: Exposing raw internal errors to clients can leak sensitive information such as file paths, database structures, or underlying software configurations, aiding attackers in reconnaissance.
🔧 Fix: I updated the
catchblocks for these handlers to generate a correlation ID, log the raw error securely server-side, and return a sanitized, generic message to the client usingthis.formatErrorForClient(error, correlationId).✅ Verification: Verified by running the full test suite (
npm run test), which asserts thatValidation error:responses include the dynamic correlation ID and do not expose stack traces.PR created automatically by Jules for task 12616939701943940330 started by @davidruzicka