🛡️ Sentinel: [HIGH] Fix path traversal in URL interpolation#240
🛡️ Sentinel: [HIGH] Fix path traversal in URL interpolation#240davidruzicka wants to merge 1 commit into
Conversation
This fixes a high-priority security vulnerability where path parameters like `../admin` were not fully encoded in `CompositeExecutor` and `MCPServer`, allowing them to escape the intended API path. Now dot characters (`.`) are safely encoded as `%2E` to prevent directory traversal attacks during URL interpolation. Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This PR addresses a critical security vulnerability reported by Sentinel:
Vulnerability: Path Traversal in Composite Tool Execution
Impact:
CompositeExecutorsubstituted user-provided arguments directly into API path templates without escaping dots. Input like../admincould resolve toGET /admin, allowing access to unintended API endpoints.Fix: Modified
encodePathSegmentinsrc/mcp/mcp-server.tsandresolvePathinsrc/tooling/composite-executor.tsto replace dot characters (.) with%2Eafter standardencodeURIComponent.Verification: Added
src/tooling/composite-executor-security.test.tsto ensure path traversal attempts are safely encoded to%2E%2Eand executed the full test suite (npm run test), which passed.PR created automatically by Jules for task 4876818639075587945 started by @davidruzicka