Skip to content

🛡️ Sentinel: [HIGH] Fix path traversal in URL interpolation#240

Open
davidruzicka wants to merge 1 commit into
mainfrom
jules-4876818639075587945-aa1b8dad
Open

🛡️ Sentinel: [HIGH] Fix path traversal in URL interpolation#240
davidruzicka wants to merge 1 commit into
mainfrom
jules-4876818639075587945-aa1b8dad

Conversation

@davidruzicka
Copy link
Copy Markdown
Owner

This PR addresses a critical security vulnerability reported by Sentinel:

Vulnerability: Path Traversal in Composite Tool Execution
Impact: CompositeExecutor substituted user-provided arguments directly into API path templates without escaping dots. Input like ../admin could resolve to GET /admin, allowing access to unintended API endpoints.
Fix: Modified encodePathSegment in src/mcp/mcp-server.ts and resolvePath in src/tooling/composite-executor.ts to replace dot characters (.) with %2E after standard encodeURIComponent.
Verification: Added src/tooling/composite-executor-security.test.ts to ensure path traversal attempts are safely encoded to %2E%2E and executed the full test suite (npm run test), which passed.


PR created automatically by Jules for task 4876818639075587945 started by @davidruzicka

This fixes a high-priority security vulnerability where path parameters like `../admin` were not fully encoded in `CompositeExecutor` and `MCPServer`, allowing them to escape the intended API path. Now dot characters (`.`) are safely encoded as `%2E` to prevent directory traversal attacks during URL interpolation.

Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant