π‘οΈ Sentinel: [MEDIUM] Fix Error Message Leakage in JSON-RPC Responses#242
π‘οΈ Sentinel: [MEDIUM] Fix Error Message Leakage in JSON-RPC Responses#242davidruzicka wants to merge 1 commit into
Conversation
- Sanitize JSON-RPC error responses using formatErrorForClient - Log original raw errors with correlationId on the backend - Add regression test updates for mcp-server-apps Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Reportβ
All modified and coverable lines are covered by tests. π’ Thoughts on this report? Let us know! |
π¨ Severity: MEDIUM
π‘ Vulnerability: Unsanitized error messages were directly returned in JSON-RPC API responses for
prompts/get,resources/read, andcompletion/completemethods, potentially leaking sensitive configuration paths or tokens viaError.messageon the client-side.π― Impact: If a backend operation crashed due to a bad configuration or token issue, the raw exception trace/message could be sent to the user, bypassing our secure error formatting.
π§ Fix: Updated the
catchblocks in these three JSON-RPC methods to correctly use the internalgenerateCorrelationId()function and log the raw error context only on the backend server logs. The client-facing error message now leveragesthis.formatErrorForClient(error, correlationId)to scrub sensitive information.β Verification: Ran the full test suite and updated
mcp-server-apps.test.tsto expect generic validation strings instead of raw error dumps. Tests passed successfully.PR created automatically by Jules for task 10783194581880560094 started by @davidruzicka