🛡️ Sentinel: [CRITICAL] Fix Path Traversal in composite-executor and mcp-server#249
🛡️ Sentinel: [CRITICAL] Fix Path Traversal in composite-executor and mcp-server#249davidruzicka wants to merge 1 commit into
Conversation
…mcp-server 🚨 Severity: CRITICAL 💡 Vulnerability: User input injected into API path endpoints could contain `..` which `encodeURIComponent` does not encode, causing directory traversal against backend server APIs. 🎯 Impact: Attackers could access unauthorized APIs. 🔧 Fix: Update `encodeURIComponent` to manually `.replace(/\./g, '%2E')` for all dots during parameter interpolation in `mcp-server.ts` and `composite-executor.ts`. ✅ Verification: Ran unit tests covering `CompositeExecutor` security testing showing failure prior and passing post-fix. Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 983b6a5dfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private encodePathSegment(value: unknown): string { | ||
| const val = String(value); | ||
| return val.includes('/') ? encodeURIComponent(val) : val; | ||
| return encodeURIComponent(val).replace(/\./g, '%2E'); |
There was a problem hiding this comment.
This change now percent-encodes every path value unconditionally, so inputs that are already URL-encoded (for example group%2Fproject, which is explicitly supported in profile parameter docs) are transformed to group%252Fproject. That breaks existing callers that pass encoded project/file paths, because backends like GitLab will receive the wrong identifier and return not found/invalid path errors. The previous behavior intentionally left already-encoded values intact when they did not contain raw /, so this is a backward-incompatible regression in core request routing.
Useful? React with 👍 / 👎.
1 participant
🛡️ Sentinel: [CRITICAL] Fix Path Traversal in composite-executor and mcp-server
🚨 Severity: CRITICAL
💡 Vulnerability: User input injected into API path endpoints could contain
..whichencodeURIComponentdoes not encode, causing directory traversal against backend server APIs.🎯 Impact: Attackers could access unauthorized APIs.
🔧 Fix: Update
encodeURIComponentto manually.replace(/\./g, '%2E')for all dots during parameter interpolation inmcp-server.tsandcomposite-executor.ts.✅ Verification: Ran unit tests covering
CompositeExecutorsecurity testing showing failure prior and passing post-fix.PR created automatically by Jules for task 12759696308919767677 started by @davidruzicka