🛡️ Sentinel: [CRITICAL] Fix path traversal in URL interpolation#255
🛡️ Sentinel: [CRITICAL] Fix path traversal in URL interpolation#255davidruzicka wants to merge 1 commit into
Conversation
Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fde96ee4bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const val = String(value); | ||
| return val.includes('/') ? encodeURIComponent(val) : val; | ||
| // URL-encode slashes and dots to prevent path traversal when interpolating path parameters | ||
| return (val.includes('/') || val.includes('.')) ? encodeURIComponent(val).replace(/\./g, '%2E') : val; |
There was a problem hiding this comment.
Encoding dots to %2E here does not stop traversal for . or .. inputs, because the URL parser used by request construction (fetch/WHATWG URL in HttpClient.requestInternal) normalizes %2E and %2E%2E path segments before sending the request. With an attacker-controlled path parameter like id: "..", the resolved path can still collapse from /users/%2E%2E/profile to /profile, so this fix leaves the traversal primitive reachable; these segment values need to be explicitly rejected (and the same logic applies to the analogous change in CompositeExecutor.resolvePath).
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal vulnerability when substituting variables in URLs using
encodeURIComponentwhich does not escape dots (.). This could allow attackers to traverse directories by providing inputs like../.🎯 Impact: Attackers could manipulate API paths to access unintended endpoints or files.
🔧 Fix: Added explicit
.replace(/\./g, '%2E')after callingencodeURIComponent()during URL variable interpolation insrc/tooling/composite-executor.tsandsrc/mcp/mcp-server.ts. This ensures that dots are properly encoded and treated as part of the segment rather than path traversal directives.✅ Verification: Ran
npm run testensuring the relevant security tests pass and no functionality breaks. Also added a journal entry in.jules/sentinel.mddocumenting this finding.PR created automatically by Jules for task 13559895342011619317 started by @davidruzicka