🛡️ Sentinel: [HIGH] Fix Path Traversal via Parameter Injection#258
🛡️ Sentinel: [HIGH] Fix Path Traversal via Parameter Injection#258davidruzicka wants to merge 1 commit into
Conversation
Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9fbcdcb66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private encodePathSegment(value: unknown): string { | ||
| const val = String(value); | ||
| return val.includes('/') ? encodeURIComponent(val) : val; | ||
| return encodeURIComponent(val).replace(/\./g, '%2E'); |
There was a problem hiding this comment.
This now runs every path parameter through encodeURIComponent, which double-encodes IDs that are already URL-encoded (for example group%2Fproject becomes group%252Fproject). That breaks documented GitLab usage where project_id may be passed as an encoded path, causing lookups by namespace/project path to fail (typically 404) even though they worked before this commit.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Path traversal vulnerability in URL paths when injecting user input containing
... The previous use ofencodeURIComponentcorrectly encodes/but leaves.intact, which could allow path traversals if normalized by a client before the request is dispatched or sent to the backend API.🎯 Impact: An attacker could potentially navigate out of the intended URL bounds (e.g. into an admin or unauthorized path).
🔧 Fix: Updated the
encodePathSegmentmethod insrc/mcp/mcp-server.tsand the substitution logic insrc/tooling/composite-executor.tsto replace.with%2Eafter applyingencodeURIComponent. HTTP clients do not normalize%2E%2E/, thereby preserving the explicit structure and eliminating the client-side path traversal vector.✅ Verification: Ran
npm run testandnpm run test:unit src/tooling/composite-executor-security.test.tssuccessfully. The expected behaviors verify that inputs are correctly encoded to%2E%2E.PR created automatically by Jules for task 10807907889283959323 started by @davidruzicka