🛡️ Sentinel: [CRITICAL] Fix Path Traversal in Path Parameters#259
🛡️ Sentinel: [CRITICAL] Fix Path Traversal in Path Parameters#259davidruzicka wants to merge 1 commit into
Conversation
This commit updates `CompositeExecutor` and `MCPServer` to explicitly URL-encode dot (`.`) characters in path parameters. Previously, standard `encodeURIComponent` was used, which correctly encoded slashes but allowed dots to pass through unencoded. This allowed a malicious user to craft input like `../admin` that would bypass application-level checks and be evaluated by backend systems as directory traversal sequences. By manually substituting `%2E` for `.`, we ensure that these sequences are safely processed as literal string values by backend routers. Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f00d3dbf47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private encodePathSegment(value: unknown): string { | ||
| const val = String(value); | ||
| return val.includes('/') ? encodeURIComponent(val) : val; | ||
| return val.includes('/') || val.includes('.') ? encodeURIComponent(val).replace(/\./g, '%2E') : val; |
There was a problem hiding this comment.
This change breaks a documented input format when the ID contains dots: for values like group%2Fmy.project (URL-encoded namespaced path), the new val.includes('.') branch calls encodeURIComponent and turns %2F into %252F, so the backend receives a different identifier and typically returns not found. Before this commit, the same input passed through unchanged unless it contained a raw slash. The regression affects users who follow the profile guidance to pass URL-encoded project paths, especially for common dotted project names.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal / SSRF via unencoded
.characters in templated URL path parameters.🎯 Impact: A user passing
../adminas an ID could force the server's backend HTTP client to traverse directories, potentially accessing unintended API routes or bypassing proxy restrictions.🔧 Fix: Applied
.replace(/\./g, '%2E')afterencodeURIComponent()anywhere path parameters are resolved dynamically (inCompositeExecutor.resolvePathandMCPServer.encodePathSegment).✅ Verification: Confirmed via
npm run testand explicit updates tosrc/tooling/composite-executor-security.test.tsto assert that.is encoded.PR created automatically by Jules for task 7154718388751806891 started by @davidruzicka