Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .jules/sentinel.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,4 @@ Error messages should never include raw values from sensitive sources like envir
**Prevention:**
1. Avoid including raw values in error messages when the source is potentially sensitive (env vars, auth headers).
2. Use generic error messages for validation failures of sensitive data.
## 2026-02-24 - [MEDIUM] Environment Variable Leakage in Error Messages\n\n**Vulnerability:**\nError messages for environment variable configuration were returning the raw value string. If a user configured it to point to a sensitive environment variable, the secret value would be exposed in the error message.\n\n**Learning:**\nError messages should never include raw values from sensitive sources like environment variables, even for validation errors. Configuration errors can easily lead to secrets being treated as normal values.\n\n**Prevention:**\n1. Avoid including raw values in error messages when the source is potentially sensitive (env vars, auth headers).\n2. Use generic error messages for validation failures of sensitive data.\n
2 changes: 1 addition & 1 deletion src/automation/artifact-signing-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ function parseExplicitBoolean(value: string | undefined, envName: string): boole
return false;
}

throw new ConfigurationError(`${envName} must be either 'true' or 'false', got '${normalized}'.`);
throw new ConfigurationError(`${envName} must be either 'true' or 'false'.`);
}
2 changes: 1 addition & 1 deletion src/mcp/mcp-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2483,7 +2483,7 @@ export class MCPServer {
const parsed = Number(raw);
if (Number.isNaN(parsed) || parsed <= 0) {
throw new ConfigurationError(
`Invalid MCP4_TOOL_FILTER_WARN_THRESHOLD_PCT: expected positive number, got '${raw}'.`
`Invalid MCP4_TOOL_FILTER_WARN_THRESHOLD_PCT: expected positive number.`
);
}
return parsed;
Expand Down
2 changes: 1 addition & 1 deletion src/tool-filter/config/env-config-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class EnvConfigParser {
}

throw new ConfigurationError(
`MCP4_TOOL_FILTER_ALLOW_CATEGORIES supports only 'list' and 'read', got '${entry}'`
`MCP4_TOOL_FILTER_ALLOW_CATEGORIES supports only 'list' and 'read'.`
);
}

Expand Down
Loading