Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix information leakage in JSON-RPC handlers#263

Open
davidruzicka wants to merge 1 commit into
mainfrom
sentinel-error-leak-fix-15313534493480958067
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Fix information leakage in JSON-RPC handlers#263
davidruzicka wants to merge 1 commit into
mainfrom
sentinel-error-leak-fix-15313534493480958067

Conversation

@davidruzicka

Copy link
Copy Markdown
Owner

πŸ›‘οΈ Sentinel: [MEDIUM] Fix information leakage in JSON-RPC handlers

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Information Leakage. The prompts/get, resources/read, and completion/complete JSON-RPC handlers directly returned (error as Error).message to clients, potentially leaking internal stack traces or sensitive error details.
🎯 Impact: Attackers could gain insights into the server's internal state, filesystem structure, or backend technologies via verbose error messages.
πŸ”§ Fix: Wrapped the error handling logic to generate a secure correlationId, log the raw error internally using this.logger.error, and format the client response using this.formatErrorForClient(error, correlationId). Updated related string tests to match the new format.
βœ… Verification: Ran npm run test, and 3190 tests passed, validating both the functionality and the updated test assertions.


PR created automatically by Jules for task 15313534493480958067 started by @davidruzicka

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Information Leakage. The `prompts/get`, `resources/read`, and `completion/complete` JSON-RPC handlers directly returned `(error as Error).message` to clients, potentially leaking internal stack traces or sensitive error details.
🎯 Impact: Attackers could gain insights into the server's internal state, filesystem structure, or backend technologies via verbose error messages.
πŸ”§ Fix: Wrapped the error handling logic to generate a secure `correlationId`, log the raw error internally using `this.logger.error`, and format the client response using `this.formatErrorForClient(error, correlationId)`. Updated related string tests to match the new format.
βœ… Verification: Ran `npm run test`, and 3190 tests passed, validating both the functionality and the updated test assertions.

Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… All tests successful. No failed tests found.

πŸ“’ Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant