Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Add missing Strict-Transport-Security and X-XSS-Protection headers#265

Open
davidruzicka wants to merge 1 commit into
mainfrom
sentinel/add-hsts-and-xss-protection-headers-462714723753174629
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Add missing Strict-Transport-Security and X-XSS-Protection headers#265
davidruzicka wants to merge 1 commit into
mainfrom
sentinel/add-hsts-and-xss-protection-headers-462714723753174629

Conversation

@davidruzicka
Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Missing Strict-Transport-Security header to enforce HTTPS and missing X-XSS-Protection: 0 to disable legacy browser auditors (which is the current industry best practice recommended by OWASP).
🎯 Impact: Without HSTS, clients may be vulnerable to downgrade attacks. Without X-XSS-Protection: 0, older browsers with flawed built-in auditors can sometimes be exploited.
πŸ”§ Fix: Appended both headers to the middleware that sets security headers in src/transport/http-transport.ts.
βœ… Verification: Ran unit tests src/transport/http-transport-security.test.ts to ensure headers are verified correctly, and ran the full suite via npm run test to verify no regressions.


PR created automatically by Jules for task 462714723753174629 started by @davidruzicka

…-Protection headers

Added `Strict-Transport-Security` to enforce HTTPS for clients and `X-XSS-Protection: 0` to disable problematic legacy browser XSS auditors. Also updated tests to verify their presence.

Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… All tests successful. No failed tests found.

πŸ“’ Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant