π‘οΈ Sentinel: [MEDIUM] Add missing Strict-Transport-Security and X-XSS-Protection headers#265
Conversation
β¦-Protection headers Added `Strict-Transport-Security` to enforce HTTPS for clients and `X-XSS-Protection: 0` to disable problematic legacy browser XSS auditors. Also updated tests to verify their presence. Co-authored-by: davidruzicka <14172985+davidruzicka@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Reportβ
All modified and coverable lines are covered by tests. π’ Thoughts on this report? Let us know! |
π¨ Severity: MEDIUM
π‘ Vulnerability: Missing
Strict-Transport-Securityheader to enforce HTTPS and missingX-XSS-Protection: 0to disable legacy browser auditors (which is the current industry best practice recommended by OWASP).π― Impact: Without HSTS, clients may be vulnerable to downgrade attacks. Without
X-XSS-Protection: 0, older browsers with flawed built-in auditors can sometimes be exploited.π§ Fix: Appended both headers to the middleware that sets security headers in
src/transport/http-transport.ts.β Verification: Ran unit tests
src/transport/http-transport-security.test.tsto ensure headers are verified correctly, and ran the full suite vianpm run testto verify no regressions.PR created automatically by Jules for task 462714723753174629 started by @davidruzicka