correct support of unicode texts #266 #236#279
Open
se-ti wants to merge 1 commit into
Open
Conversation
Author
|
@davidshimjs, could you please merge it, or reject, or smth else. |
segdeha
added a commit
to segdeha/qrcodejs
that referenced
this pull request
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can easily test, that library draws wrong QR-codes for some special inputs like
new QRCode(elem "\x80");
new QRCode(elem, "\u0800"); // samaritan letter alaf
or any string, conatining chars with codes greater than 0xFFFF
new QRCode(elem, "🔥");
The reasons are
One should notice, that js support for unicode strings is pretty poor:
"🔥".length === 2, even though every human would say, this string has one 'character'.
P.S. qrcode.min.js should be updated also, i suppose, but i'm not sure which settings should be used, except smth like "preserve ie 6 compatibility"