Use disabledText only when multiselect is actually disabled#1029
Open
adeeb1 wants to merge 13 commits into
Open
Use disabledText only when multiselect is actually disabled#1029adeeb1 wants to merge 13 commits into
adeeb1 wants to merge 13 commits into
Conversation
Remove unnecessary condition causing the bug.
Retrieve the number of options rather than the number of selected options.
adeeb1
changed the title
Fix a selector typo in selectAll. Prevent the dropdown from closing after each click.
Fix styles. and remove old styles.
Support Bootstrap 4
Fix Collapsible Opt Groups and tests for Bootstrap 4
Disable the numberDisplayed option with a value of -1 instead of 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #715 to fix #714.
Previously, the
disabledTextwill display if no options are selected on the multiselect anddisableIfEmptyis set totrue, even if there are options present in the multiselect. I changed the condition to check for the number of total options in the select rather than the number of selected options. Whether or not any options are selected is irrelevant.