update python packaging to work with newer tool-chains#3102
Merged
Conversation
E.g. tested on windows, newer version of visual studio and newest python version.
davisking
commented
Aug 11, 2025
Comment on lines
-34
to
-36
| if (MSVC) | ||
| include(${CMAKE_CURRENT_LIST_DIR}/../../dlib/cmake_utils/tell_visual_studio_to_use_static_runtime.cmake) | ||
| endif() |
Owner
Author
There was a problem hiding this comment.
This makes building fail in the very latest version of visual studio and the python interpreter in windows now.
davisking
commented
Aug 11, 2025
| from packaging.version import Version, parse as parse_version | ||
| from setuptools import find_packages, setup, Extension | ||
| from setuptools.command.build_ext import build_ext | ||
| from distutils.version import LooseVersion |
Owner
Author
There was a problem hiding this comment.
distutils is no more in the latest python version
davisking
added a commit
to smu-sc-gj/dlib
that referenced
this pull request
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. tested on windows, newer version of visual studio and newest python version.