add option to disable -Werror on tests#3104
Closed
ribbon-otter wants to merge 2 commits intodavisking:masterfrom
Closed
add option to disable -Werror on tests#3104ribbon-otter wants to merge 2 commits intodavisking:masterfrom
ribbon-otter wants to merge 2 commits intodavisking:masterfrom
Conversation
Contributor
Author
|
After thinking about this more, I am not convinced this is a useful feature to have, since passing an argument to cmake isn't much less difficult than just manually editing the CMakeLists.txt file temporarily when I need to. I won't feel bad if you reject this pull request. |
Owner
|
Yeah, someone can just edit the file instead. And when there is some problem we should fix it anyway instead of flipping a switch to ignore it too :D Thanks for the PR though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a cmake option to disable -Werror on tests. This is helpful because when dealing with multiple disparate sources of warnings, it is nice to be able to compile and run tests so see if your fix for one, introduced new problems or not.
-Werror defaults to on. Use
cmake .. -DWerror=OFFinside the test build directory to disable.