Changed: Long paths to truncate at hard limit of 255 per folder/file

Author: NhKPaNdA

baseunits/FMDOptions.pas

@@ -103,6 +103,7 @@ interface
   OptionLetFMDDo: TFMDDo = DO_NOTHING;
   OptionDeleteCompletedTasksOnClose: Boolean = False;
   OptionSortDownloadsOnNewTasks: Boolean = False;
+  OptionLongNamePaths: Boolean = False;
 
   // saveto
   OptionChangeUnicodeCharacter: Boolean = False;

baseunits/uBaseUnit.pas

@@ -1462,7 +1462,7 @@ function CorrectPathSys(const Path: String): String;
   if Length(s) > MAX_PATHDIR then
   begin
     s := MainForm.CheckLongNamePaths(s);
-    if not MainForm.cbOptionEnableLongNamePaths.Checked then
+    if not OptionLongNamePaths then
     begin
       SetLength(s, MAX_PATHDIR);
     end;
@@ -1793,41 +1793,59 @@ function CustomRename(const AString, AWebsite, AMangaName, AAuthor, AArtist, ACh
   Result := AString;
 
   // for rename chapter only
-  if AChapter <> '' then begin
+  if AChapter <> '' then
+  begin
     // numbering/index
     if (Pos(CR_NUMBERING, Result) = 0) and (Pos(CR_CHAPTER, Result) = 0) then
+    begin
       Result := ANumbering + Result;
+    end;
     Result := StringReplaceBrackets(Result, CR_NUMBERING, ANumbering, [rfReplaceAll]);
 
     // pad number
     fchapter := Trim(AChapter);
     if OptionConvertDigitVolume then
     begin
       if OptionConvertDigitChapter then
-        VolumeChapterPadZero(fchapter, OptionConvertDigitVolumeLength, OptionConvertDigitChapterLength)
+      begin
+        VolumeChapterPadZero(fchapter, OptionConvertDigitVolumeLength, OptionConvertDigitChapterLength);
+      end
       else
+      begin
         VolumeChapterPadZero(fchapter, OptionConvertDigitVolumeLength, 0);
+      end;
     end
-    else
-    if OptionConvertDigitChapter then
+    else if OptionConvertDigitChapter then
+    begin
       VolumeChapterPadZero(fchapter, 0, OptionConvertDigitChapterLength);
+    end;
 
     fchapter := FixStringLocal(fchapter);
 
     Result := StringReplaceBrackets(Result, CR_CHAPTER, fchapter, [rfReplaceAll]);
 
     if Result = '' then
+    begin
       Result := ANumbering;
+    end;
   end;
 
   Result := StringReplaceBrackets(Result, CR_WEBSITE, FixStringLocal(AWebsite), [rfReplaceAll]);
   Result := StringReplaceBrackets(Result, CR_MANGA, FixStringLocal(AMangaName), [rfReplaceAll]);
   Result := StringReplaceBrackets(Result, CR_AUTHOR, FixStringLocal(AAuthor), [rfReplaceAll]);
   Result := StringReplaceBrackets(Result, CR_ARTIST, FixStringLocal(AArtist), [rfReplaceAll]);
   Result := StringReplaceBrackets(Result, CR_FILENAME, FixStringLocal(AFileName), [rfReplaceAll]);
-  if Result = '' then Result := FixStringLocal(AMangaName);
+  if Result = '' then
+  begin
+    Result := FixStringLocal(AMangaName);
+  end;
 
-  if Result = '' then Exit;
+  if Result = '' then
+  begin
+    Exit;
+  end;
+
+  Result := MainForm.CheckSingularCharacterLimit(Result);
 
   // remove pathdelim
   Result := TrimChar(Result, AllowDirectorySeparators);

baseunits/uDownloadsManager.pas

@@ -536,9 +536,15 @@ function TTaskThread.GetFileName(const AWorkId: Integer): String;
   Result := '';
   if (Container.FileNames.Count = Container.PageLinks.Count) and
     (AWorkId < Container.FileNames.Count) then
+  begin
     Result := Container.FileNames[AWorkId];
+  end;
+
   if Result = '' then
+  begin
     Result := Format('%.3d', [AWorkId + 1]);
+  end;
+
   Result := StringReplace(CurrentCustomFileName, CR_FILENAME, Result, [rfReplaceAll]);
   {$IFDEF WINDOWS}
   s := UTF8Decode(Result);
@@ -766,7 +772,7 @@ procedure TTaskThread.SetCurrentWorkingDir(AValue: String);
   {$IFDEF Windows}
   s := UTF8Decode(FCurrentWorkingDir);
 
-  if MainForm.cbOptionEnableLongNamePaths.Checked then
+  if OptionLongNamePaths then
   begin
     FCurrentMaxFileNameLength := FMDMaxImageFilePath + Length(s);
   end

mangadownloader/forms/frmMain.pas

@@ -21,7 +21,7 @@ interface
   ExtCtrls, ComCtrls, Buttons, Spin, Menus, VirtualTrees, RichMemo, simpleipc, process,
   lclproc, types, LCLIntf, EditBtn, GroupedEdit, PairSplitter, MultiLog,
   FileChannel, FileUtil, LazStringUtils, TAGraph, TASources, TASeries, TATools,
-  AnimatedGif, uBaseUnit, uDownloadsManager, uFavoritesManager,
+  AnimatedGif, uBaseUnit, uDownloadsManager, uFavoritesManager, StrUtils,
   uSilentThread, uMisc, uGetMangaInfosThread, frmDropTarget, frmAccountManager,
   frmAccountSet, frmWebsiteOptionCustom, frmCustomColor, frmLogger, frmTransferFavorites,
   frmLuaModulesUpdater, CheckUpdate, DBDataProcess, uDarkStyleParams, uWin32WidgetSetDark,
@@ -773,6 +773,9 @@   TMainForm = class(TForm)
 
     procedure AddChapterNameToList;
 
+    // Check and trim to max 255 character limit per folder/file
+    function CheckSingularCharacterLimit(APath: String; ALimit: Integer = 255): String;
+
     // Check and set path for long path compatibilty
     function CheckLongNamePaths(APath: String): String;
 
@@ -5375,18 +5378,53 @@ procedure TMainForm.AddSilentThread(URL: string);
 
   AddSilentThread(URL, mt);
 end;
+     
+function TMainForm.CheckSingularCharacterLimit(APath: String; ALimit: Integer = 255): String;
+var
+  TruncLength: Integer;
+  FileNamePos: Integer = 0;
+  HasFileName: Boolean = False;
+  CharsToTrim: Set of Char;
+begin
+  ALimit := Min(Alimit, 255);
+  CharsToTrim := [' ', '.'];
+  HasFileName := APath.Contains(CR_FILENAME);
+
+  if HasFileName then
+  begin
+    FileNamePos := Pos(CR_FILENAME, APath);
+    ALimit := ALimit - 3 - 5;
+  end;
+
+  if Length(APath) >= ALimit then
+  begin
+    TruncLength := LastDelimiter(' ', Copy(APath, 1, ALimit));
+    APath := Copy(APath, 1, TruncLength);
+    APath := TrimRightSet(APath, CharsToTrim);
+  end;
+
+  if HasFileName then
+  begin
+    if FileNamePos > Alimit then
+    begin
+      APath := APath + CR_FILENAME;
+    end;
+  end;
+
+  Result := APath;
+end;
 
 function TMainForm.CheckLongNamePaths(APath: String): String;
 begin
-  if cbOptionEnableLongNamePaths.Checked then
+  if OptionLongNamePaths then
   begin
     if Pos('\\?\', APath) = 0 then
     begin
       APath := '\\?\' + APath;
     end;
-  end;
 
-  Result := APath;
+    Result := APath;
+  end;
 end;
 
 function TMainForm.TrimPath(APath: String): String;
@@ -6136,6 +6174,7 @@ procedure TMainForm.ApplyOptions;
     OptionEnableLoadCover := cbOptionEnableLoadCover.Checked;
     OptionDeleteCompletedTasksOnClose := cbOptionDeleteCompletedTasksOnClose.Checked;
     OptionSortDownloadsOnNewTasks := cbOptionSortDownloadsOnNewTasks.Checked;
+    OptionLongNamePaths := cbOptionEnableLongNamePaths.Checked;
     DLManager.DB.AutoVacuum:=cbOptionVacuumDatabasesOnExit.Checked;
     FavoriteManager.DB.AutoVacuum:=cbOptionVacuumDatabasesOnExit.Checked;