Typehint most of magic.py#1322
Merged
Merged
Conversation
* add type hints and needed imports * account for magic.py passing init_command=None to connect(), instead of str * doubly ignore undefined get_ipython() * update the changelog entry to reflect that typehinting is complete, outside of the test suite Incidentally remove a "type: ignore" from main.py which is no longer needed. No meaningful return value was deduced for mycli_line_magic().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
magic.pypassinginit_command=Nonetoconnect(), instead ofstrget_ipython()Incidentally remove a
type: ignorecomment frommain.pywhich is no longer needed.No meaningful return value was deduced for
mycli_line_magic().Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.