Skip to content

Only read "my" configuration files once, rather than once per call to…#1339

Merged
rolandwalker merged 1 commit into
dbcli:mainfrom
fabzzap:main
Sep 4, 2025
Merged

Only read "my" configuration files once, rather than once per call to…#1339
rolandwalker merged 1 commit into
dbcli:mainfrom
fabzzap:main

Conversation

@fabzzap

@fabzzap fabzzap commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

… read_my_cnf_files

Description

Only read "my" configuration files once, rather than once per call to read_my_cnf_files

read_my_cnf_files used to call read_config_files every time. Now, read_config_files is called once with parameter self.cnf_files. This way, it is avoided to re-read the same file(s) several times from the file system

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).
  • I ran uv run ruff check && uv run ruff format to lint and format the code.

@rolandwalker

Copy link
Copy Markdown
Contributor

This looks like a good idea!

@rolandwalker

Copy link
Copy Markdown
Contributor

Is this ready for review?

@fabzzap

fabzzap commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

Yes, the CI passes

@rolandwalker

Copy link
Copy Markdown
Contributor

Solid!

@rolandwalker rolandwalker merged commit 70bd289 into dbcli:main Sep 4, 2025
8 checks passed
@rolandwalker

Copy link
Copy Markdown
Contributor

Released in v1.38.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants