Make batch execution noninteractive by default#1951
Merged
Conversation
rolandwalker
force-pushed
the
RW/batch-default-non-interactive
branch
from
d7041fb to
44869ab
Compare
scottnemes
reviewed
Jun 23, 2026
| clickdc=None, | ||
| help='Warn before running a destructive query.', | ||
| ) | ||
| batch_warn: bool = clickdc.option( |
Contributor
There was a problem hiding this comment.
Looks like destructive_warning is set to True by default, but the new batch_warn is False by default (default Click value for bool). Might be worth calling that out in the changelog, or setting batch_warn to True by default. Could see that one getting some people unexpectedly
Contributor
Author
There was a problem hiding this comment.
The intent of the PR is for batch mode to be non-interactive by default. Added to the changelog, updating the name of the flag as well.
* replace --noninteractive flag with --warn-batch, with an inverted meaning * when --warn-batch is set, it overrides myclirc's destructive_warning setting * let --execute work exactly like --batch * send destructive-query confirmation prompts to the standard error, since users running batch scripts will often have the standard output redirected This is a breaking change, not least because the --noninteractive flag no longer has an effect, and disappears from the docs. But passing it causes a Click warning referring the user to --warn-batch. Preparation for release 2.0.
rolandwalker
force-pushed
the
RW/batch-default-non-interactive
branch
from
44869ab to
51c1839
Compare
scottnemes
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--noninteractiveflag with--warn-batch, with an inverted meaning--warn-batchis set, it overrides myclirc'sdestructive_warningsetting--executework exactly like--batchThis is a breaking change, not least because the
--noninteractiveflag no longer has an effect, and disappears from the docs. But passing it causes a Click warning referring the user to--warn-batch.Preparation for release 2.0.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).