fix: Fix row limit detection for multiline LIMIT clauses#1594
Open
Anjanna wants to merge 2 commits intodbcli:mainfrom
Open
fix: Fix row limit detection for multiline LIMIT clauses#1594Anjanna wants to merge 2 commits intodbcli:mainfrom
Anjanna wants to merge 2 commits intodbcli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fixes #1592
Fixes pgcli's row limit detection when a SQL query contains a
LIMITclause followed by a newline.Previously, pgcli checked for
LIMITusing a string search for"limit ", so queries like this were not recognized as already limited:As a result, pgcli could incorrectly apply its configured row limit and show the row-limit warning. This change uses parsed SQL tokens to detect real LIMIT keywords, including multiline and tab-separated formatting, while ignoring LIMIT inside strings or comments.
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).