Conversation
…r SkipNavLinks and SkipNavShortcutsLink
Contributor
Author
|
devnaumov
requested changes
Mar 27, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 14 |
TIP This summary will be updated as you push new changes. Give us feedback
devnaumov
requested changes
Apr 2, 2026
| display: flex; | ||
| } | ||
|
|
||
| .dbv-kit-skip-nav__link { |
Member
There was a problem hiding this comment.
Why we use dbv kit prefixes here?
Wroud
requested changes
Apr 2, 2026
Comment on lines
+14
to
+16
| export function SkipNavShortcutsLink(): React.ReactElement { | ||
| const translate = useTranslate(); | ||
| const commonDialogService = useService(CommonDialogService); |
|
|
||
| export function SkipNavLinks(): React.ReactElement { | ||
| const translate = useTranslate(); | ||
| const skipNavService = useService(SkipNavService); |
Member
There was a problem hiding this comment.
you should use observable with useTranslate
Wroud
approved these changes
Apr 3, 2026
sergeyteleshev
approved these changes
Apr 3, 2026
devnaumov
approved these changes
Apr 6, 2026
devnaumov
deleted the
7251-cb-add-skip-to-content-panel-for-keyboard-navigaton
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sibility
Screen.Recording.2026-03-27.at.17.58.23.mov