Skip to content

Fix Statement.getUpdateCount: return -1 when current result is a ResultSet #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IceboxDev wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix Statement.getUpdateCount: return -1 when current result is a ResultSet #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...aver.jdbc.driver.libsql/src/main/java/com/dbeaver/jdbc/driver/libsql/LibSqlStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,21 +121,29 @@ public ResultSet getResultSet() throws SQLException {
@Override
public int getUpdateCount() throws SQLException {
if (executionResult == null) {
throw new LibSqlException("No update count before statement execute");
return -1;
}
if (executionResult.getColumns() != null && !executionResult.getColumns().isEmpty()) {
return -1;
}
return (int) executionResult.getUpdateCount();
}

@Override
public long getLargeUpdateCount() throws SQLException {
if (executionResult == null) {
throw new LibSqlException("No update count before statement execute");
return -1;
}
if (executionResult.getColumns() != null && !executionResult.getColumns().isEmpty()) {
return -1;
}
return executionResult.getUpdateCount();
}

@Override
public boolean getMoreResults() throws SQLException {
executionResult = null;
resultSet = null;
return false;
}

Expand All @@ -151,6 +159,8 @@ public int getFetchDirection() throws SQLException {

@Override
public boolean getMoreResults(int current) throws SQLException {
executionResult = null;
resultSet = null;
return false;
}
@Override
Expand Down