Feat/user crud unit tests by Aline-Pinotti · Pull Request #46 · dbfcode/java-ecommerce-async-platform

Aline-Pinotti · 2026-06-04T13:30:10Z

Summary

Implemented the complete User CRUD feature, including validation, exception handling, and unit tests.

Changes

Added UserEntity
Added UserController
Added UserRepository
Added UserDTO with Bean Validation
Implemented CRUD endpoints for user management
Added controller exception handling (ControllerHandleException)
Added custom exception support classes
Added unit tests for User components and validations

Impact

This PR introduces the User module and establishes a reusable exception handling structure for future features.

Notes

This PR establishes the foundation for user management and application-wide error handling.
Custom exception infrastructure can be reused by future modules.

maxzdosreis

Congratulations, I really liked the implementation. It just needs a few things aligned with the project standards, removing the comments, and some adjustments. It's also necessary to implement mappers (as mentioned in the comments) and implement the Swagger documentation for the controllers, always following the project standards. When submitting the PR for review, it's necessary to include evidence in the PR, such as approved tests, endpoint tests (e.g., the GET endpoint for /users in Postman), and a screenshot of the Swagger documentation.

maxzdosreis · 2026-06-09T22:47:29Z

Remove the entire ControllerExceptionHandler, as exception handling is already present in the GlobalExceptionHandler of the project. Therefore, you should add the handlers and exceptions to the GlobalExceptionHandler.

ControllerExceptionHandler removed, Handlers moved to GlobalExceptionHandler.

maxzdosreis · 2026-06-09T23:02:47Z

+@ControllerAdvice
+public class ControllerExceptionHandler {
+
+    @ExceptionHandler(MethodArgumentNotValidException.class)


The handler for MethodArgumentNotValidException is duplicated; you should evaluate the other developer's implementation to see if it's feasible for your needs, and if necessary, make changes in a way that satisfies both your implementation and the other developer's.

Refactored MethodArgumentNotValidException handler in GlobalExceptionHandler to replace this.

maxzdosreis · 2026-06-09T23:06:15Z

+
+        return ResponseEntity.status(status).body(err);
+    }
+    @ExceptionHandler(DataIntegrityViolationException.class)


Implement in GlobalExceptionHandler.

maxzdosreis · 2026-06-09T23:06:56Z

+        return ResponseEntity.status(status).body(err);
+    }
+
+    @ExceptionHandler(DuplicateResourceValidationException.class)


Implement in GlobalExceptionHandler.

maxzdosreis · 2026-06-09T23:13:12Z

Move the FieldMessage to api/src/main/java/com/orderflow/ecommerce/dtos/.
The record is an HTTP response template and should remain with the DTOS.

FieldMessage moved to api/src/main/java/com/orderflow/ecommerce/dtos/

maxzdosreis · 2026-06-10T02:41:16Z

+    }
+
+    @Test
+    void shouldUseSettersAndGetters() {


Since the entity uses Lombok, I don't see the need to perform this test; it ends up being somewhat redundant, but it can be evaluated whether it should be removed or not.

maxzdosreis · 2026-06-10T02:42:21Z

+    }
+
+    @Test
+    void shouldHaveNullsWhenUsingNoArgsConstructor() {


It only checks id, name, and email for null values, but the no-args constructor leaves all fields as null. Either check all or check none—doing it halfway gives a false sense of coverage.

maxzdosreis · 2026-06-10T02:44:30Z

+    }
+
+    @Test
+    void equalsAndHashCodeShouldBeBasedOnlyOnId() {


Missing the scenario of two objects with null IDs, something like:
User d = new User();
User e = new User();

maxzdosreis · 2026-06-10T02:48:38Z

Did all the tests pass? Review the tests according to the necessary changes that will occur.

maxzdosreis · 2026-06-10T02:51:02Z

+    @Test
+    void updateShouldThrowDuplicateResourceExceptionWhenEmailUsedByAnother() {
+
+        UserDto dto = new UserDto(existingId, "Bob New", "someoneelse@example.com", "pw",


The password doesn't pass the regex, even though Bean Validation doesn't run in unit tests. Ideally, we should use a password that does pass the regex to simulate a real result.

dbfcode · 2026-06-13T05:31:49Z

I reviewed the PR and followed the discussion. Nice work on the implementation, Aline, and great review points from Max as well.

Overall, I think this is moving in a good direction.

Since this is Aline’s first PR in this project and the conversation has grown a bit, I think it would be helpful to summarize the remaining required changes before merging.

@maxzdosreis, could you please add a short checklist in the main PR comment with the must-have items to close this PR? Ideally, only from the points already raised, without adding new items unless something is critical.

From my side, one point I would also adjust is the 0/1 handling to use a proper boolean type.

Other than that, I believe the remaining items are already being addressed. Let’s focus on closing this task, and we can continue polishing/refactoring afterward if needed.

Great work, everyone. Thanks for the commitment.

dbfcode

see:
#46 (comment)

Aline-Pinotti and others added 17 commits May 22, 2026 13:15

feat(user): add user entity

88b988f

feat(user): add user repository

b4a54a6

refactor(user): rename taxpayer property

3f43a09

feat(user): implement user listing

36fea87

feat(user): implement user creation

aeab4c4

feat(user): implement user update

e6863ea

feat(user): implement user deletion

5d2d8ac

refactor(user): add bean validation

b05fced

test(user): add entity unit test

c029e26

refactor(user): add verify id option in delete

6e7090c

test(user): add service unit tests

3cc439c

refactor(user): add email and password bean validation

24cb12f

fix(user): fix controller annotation

8c77613

refactor(user): update password bean validation

7573b74

test(user): add controller unit tests

9b94cf3

refactor(user): improve validation exception

fe62a14

Merge branch 'main' into feat/user-crud-unit-tests

73764bc

maxzdosreis marked this pull request as draft June 9, 2026 22:34

maxzdosreis marked this pull request as ready for review June 9, 2026 22:34

maxzdosreis marked this pull request as draft June 9, 2026 22:34

maxzdosreis requested review from dbfcode and maxzdosreis June 9, 2026 22:34

maxzdosreis marked this pull request as ready for review June 9, 2026 22:34

maxzdosreis requested changes Jun 10, 2026

View reviewed changes

dbfcode requested changes Jun 13, 2026

View reviewed changes

Conversation

Aline-Pinotti commented Jun 4, 2026

Summary

Changes

Impact

Notes

Uh oh!

maxzdosreis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbfcode commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbfcode left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dbfcode commented Jun 13, 2026 •

edited

Loading