Parse port_search_count as an int#1114
Merged
fizyk merged 4 commits intodbfixtures:mainfrom May 10, 2025
Merged
Conversation
fizyk
reviewed
Mar 22, 2025
| port=get_postgresql_option("port"), | ||
| port_search_count=get_postgresql_option("port_search_count"), | ||
| # Parse as int, because if it's defined in an INI file then it'll always be a string | ||
| port_search_count=int(get_postgresql_option("port_search_count", default=5)), |
Member
There was a problem hiding this comment.
I'd defer to keeping all defaults in single place either defaults for ini or here
Contributor
Author
There was a problem hiding this comment.
Sounds good! I'll keep them in INI. This should also fix the bug where my return request.config.getoption(name) or request.config.getini(name) or default code was returning None for any falsey config setting
Contributor
Author
There was a problem hiding this comment.
(I could change it to be more careful about only coalescing when request.config.getoption(name) is None)
Contributor
Author
|
Hi again! Sorry for the delay. I got my local dev setup working and fixed the silly bug that was causing my CLI config test to fail. |
Member
|
@maxhully thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chore that needs to be done:
pipenv run towncrier create [issue_number].[type].rstTypes are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number