Skip to content

Support only PostgreSQL 14 and never versions#1253

Merged
fizyk merged 1 commit intomainfrom
issue-1250
Jan 12, 2026
Merged

Support only PostgreSQL 14 and never versions#1253
fizyk merged 1 commit intomainfrom
issue-1250

Conversation

@fizyk
Copy link
Copy Markdown
Member

@fizyk fizyk commented Jan 12, 2026 •
edited by coderabbitai bot
Loading

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number

Summary by CodeRabbit

  • Breaking Changes
    • Minimum supported PostgreSQL version increased from 10 to 14. This release will no longer function with PostgreSQL versions 13 and earlier, which will be rejected at runtime.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 12, 2026 •
edited
Loading

Walkthrough

The minimum supported PostgreSQL version is being updated from version 10 to version 14 across the codebase. This involves updating the version constant in the executor module, updating the README documentation, and adding a breaking change entry to the changelog.

Changes

Cohort / File(s) Summary
Documentation & Changelog
README.rst, newsfragments/1250.break.rst		 Updated minimum tested PostgreSQL version reference to 14; added breaking change notice for version 14 requirement
Code
pytest_postgresql/executor.py		 Bumped MIN_SUPPORTED_VERSION constant from 10 to 14; affects pre-check validation in start() method

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 PostgreSQL's marching on,
To version fourteen, strong and true,
The old guard ten has gone,
Now onwards, fresher versions brew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating minimum PostgreSQL support from version 10 to 14 across all project files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a40735 and 92bacec.

📒 Files selected for processing (3)
  • README.rst
  • newsfragments/1250.break.rst
  • pytest_postgresql/executor.py
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: fizyk
Repo: dbfixtures/pytest-postgresql PR: 1251
File: newsfragments/+3cf1375f.docs.rst:1-7
Timestamp: 2026-01-08T13:06:06.875Z
Learning: In the pytest-postgresql repository, newsfragment filenames can use hash-based identifiers (e.g., `+3cf1375f.docs.rst`) when the work was done before an issue or PR number existed, as an acceptable alternative to the standard `[issue_number].[type].rst` format.
📚 Learning: 2026-01-08T13:06:01.573Z 
Learnt from: fizyk
Repo: dbfixtures/pytest-postgresql PR: 1251
File: newsfragments/+3cf1375f.docs.rst:1-7
Timestamp: 2026-01-08T13:06:01.573Z
Learning: In the pytest-postgresql repository, allow hash-based identifiers in newsfragment filenames as an acceptable alternative to the standard [issue_number].[type].rst format when the work predates an issue or PR number. For files in the newsfragments directory, filename pattern can be +<hash>.<type>.rst (e.g., +3cf1375f.docs.rst) in addition to the usual [issue_number].[type].rst convention.

Applied to files:

  • newsfragments/1250.break.rst
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: postgresql_18 / postgres (3.12)
  • GitHub Check: postgresql_18 / postgres (3.13)
  • GitHub Check: postgresql_18 / postgres (pypy-3.11)
🔇 Additional comments (4)
newsfragments/1250.break.rst (1)

1-1: LGTM!

The newsfragment correctly documents the breaking change with the appropriate .break type and follows the [issue_number].[type].rst naming convention.

README.rst (1)

62-62: LGTM!

Documentation correctly updated to reflect the new minimum supported PostgreSQL version, consistent with the code changes in executor.py.

pytest_postgresql/executor.py (2)

60-60: LGTM!

The minimum supported version constant is correctly updated to PostgreSQL 14. The existing version check in start() (lines 141-146) will automatically enforce this new requirement.

139-148: LGTM!

The version check logic is sound. The error message helpfully indicates both the minimum required version and the currently installed version, making it easy for users to understand what action is needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fizyk fizyk merged commit 929eee0 into main Jan 12, 2026
94 of 95 checks passed
@fizyk fizyk deleted the issue-1250 branch January 12, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fizyk