Changes per review comments

Author: dbmalkovsky

modules/flowable-dmn-xml-converter/src/main/java/org/flowable/dmn/converter/child/InputEntryParser.java

@@ -104,22 +104,22 @@ protected void migrateExtensionElement(DmnExtensionElement extensionElement, Inp
 
         String elementText = extensionElement.getElementText();
         String typeRef = inputClause.getInputExpression().getTypeRef();
-        String newElementText = null;
+        String newElementText;
         if ("collection".equalsIgnoreCase(typeRef)) {
             newElementText = switch (elementText) {
                 case "IN" -> "ALL OF";
                 case "NOT IN" -> "NONE OF";
                 case "ANY" -> "ANY OF";
                 case "NOT ANY" -> "NOT ALL OF";
-                default -> newElementText;
+                default -> null;
             };
         } else {
             newElementText = switch (elementText) {
                 case "IN" -> "IS IN";
                 case "NOT IN" -> "IS NOT IN";
                 case "ANY" -> "IS IN";
                 case "NOT ANY" -> "IS NOT IN";
-                default -> newElementText;
+                default -> null;
             };
         }
 

modules/flowable-engine-common/src/main/java/org/flowable/common/engine/impl/calendar/CronExpression.java

@@ -21,6 +21,8 @@
 
 import java.io.Serializable;
 import java.text.ParseException;
+import java.time.Month;
+import java.time.Year;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.HashMap;
@@ -1601,22 +1603,7 @@ protected boolean isLeapYear(int year) {
     }
 
     protected int getLastDayOfMonth(int monthNum, int year) {
-
-        return switch (monthNum) {
-            case 1 -> 31;
-            case 2 -> isLeapYear(year) ? 29 : 28;
-            case 3 -> 31;
-            case 4 -> 30;
-            case 5 -> 31;
-            case 6 -> 30;
-            case 7 -> 31;
-            case 8 -> 31;
-            case 9 -> 30;
-            case 10 -> 31;
-            case 11 -> 30;
-            case 12 -> 31;
-            default -> throw new IllegalArgumentException("Illegal month number: " + monthNum);
-        };
+        return Month.of(monthNum).length(Year.isLeap(year));
     }
 
     private void readObject(java.io.ObjectInputStream stream) throws java.io.IOException, ClassNotFoundException {