Skip to content

Commit 882c369

Browse files
committed
Update section for mobile libraries
1 parent 4866b89 commit 882c369

1 file changed

Lines changed: 27 additions & 42 deletions

File tree

proposals/0296-Update-video-streaming-capabilities-during-ignition-cycle.md

Lines changed: 27 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,16 @@ In `SDLStreamingMediaConfiguration`:
122122
@property (strong, nonatomic, nullable) SDLSupportedStreamingRange *supportedPortraitStreamingRange;
123123

124124
@interface SDLSupportedStreamingRange : NSObject
125-
// The minimum supported normalized aspect ratio, Min value is 1
125+
// The minimum supported normalized aspect ratio, Min value is 1. (0 matches any ratio)
126126
@property (nonatomic, assign) float minimumAspectRatio;
127-
// The maximum supported normalized aspect ratio, Min value is 1
127+
// The maximum supported normalized aspect ratio, Min value is 1. (0 matches any ratio)
128128
@property (nonatomic, assign) float maximumAspectRatio;
129129
// The minimum supported diagonal screen size in inches, defaults to 0 (0 matches any size)
130130
@property (nonatomic, assign) float minimumDiagonal;
131-
// The minimum resolution to support, it overrides .minimumAspectRatio
132-
@property (nonatomic, assign) float minimumResolution;
133-
// The maximum resolution to support, it overrides .maximumAspectRatio
134-
@property (nonatomic, assign) float maximumResolution;
131+
// The minimum resolution to support
132+
@property (nonatomic, assign, nullable) SDLImageResolution *minimumResolution;
133+
// The maximum resolution to support
134+
@property (nonatomic, assign, nullable) SDLImageResolution *maximumResolution;
135135
// Check if the argument is within the [.minimumResolution, .maximumResolution] range
136136
- (BOOL)isImageResolutionInRange:(SDLImageResolution*)imageResolution;
137137
// Check if the argument is within the [.minimumAspectRatio, .maximumAspectRatio] range
@@ -142,50 +142,35 @@ In `SDLStreamingMediaConfiguration`:
142142
143143
**Android**
144144
145-
In `SdlRemoteDisplay`:
145+
In `VideoStreamManager` add new `startRemoteDisplayStream`:
146146
147147
```java
148-
public abstract Integer getMinSupportedWidth();
149-
public abstract Integer getMinSupportedHeight();
150-
public abstract Integer getMaxSupportedWidth();
151-
public abstract Integer getMaxSupportedHeight();
152-
public abstract double getMinScreenDiagonal();
153-
public abstract Double getMinAspectRatio();
154-
public abstract Double getMaxAspectRatio();
148+
public void startRemoteDisplayStream(Context context, Class<? extends SdlRemoteDisplay> remoteDisplayClass, VideoStreamingParameters parameters, final boolean encrypted, SupportedStreamingRange streamingRange)
155149
```
156150

157-
In `SdlRemoteDisplay` implementation by mobile application developers:
151+
In this way, developers will be able to pass constraints related to specific application directly into `SDLManager`
152+
where `SupportedStreamingRange`:
158153

159154
```java
160-
@Override
161-
public Integer getMinSupportedWidth() {
162-
return 800;
163-
}
164-
@Override
165-
public Integer getMinSupportedHeight() {
166-
return 600;
167-
}
168-
@Override
169-
public Integer getMaxSupportedWidth() {
170-
return 1600;
171-
}
172-
@Override
173-
public Integer getMaxSupportedHeight() {
174-
return 1200;
175-
}
176-
@Override
177-
public double getMinScreenDiagonal() {
178-
return 6;
179-
}
180-
@Override
181-
public Double getMinAspectRatio() {
182-
return 1.;
183-
}
184-
@Override
185-
public Double getMaxAspectRatio() {
186-
return 4.;
155+
public class SupportedStreamingRange {
156+
private Resolution minSupportedResolution;
157+
private Resolution maxSupportedResolution;
158+
private Double maxScreenDiagonal;
159+
private AspectRatio aspectRatio;
187160
}
188161
```
162+
In `SdlRemoteDisplay` implementation by mobile application developers:
163+
164+
Later, when alternative supported resolutions are retrieved from `HMI`, `SupportedStreamingRange` will be used to unpack data:
165+
166+
```java
167+
private List<VideoStreamingCapability> getSupportedCapabilities(
168+
Resolution minResolution,
169+
Resolution maxResolution,
170+
Double constraintDiagonalMax,
171+
AspectRatio ratioRange
172+
)
173+
```
189174

190175
#### Resolution Switching
191176

0 commit comments

Comments
 (0)