throw start workflow with queue options and no queue (#365)

Fixes #353

Author: devhawk

transact/src/main/java/dev/dbos/transact/execution/DBOSExecutor.java

@@ -1484,6 +1484,29 @@ private <T, E extends Exception> WorkflowHandle<T, E> executeWorkflow(
       return new WorkflowHandleDBPoll<>(this, workflowId);
     }
 
+    var badOptionList = new ArrayList<String>();
+    if (options.deduplicationId() != null) {
+      badOptionList.add("deduplicationId");
+    }
+
+    if (options.priority() != null) {
+      badOptionList.add("priority");
+    }
+
+    if (options.queuePartitionKey() != null) {
+      badOptionList.add("queuePartitionKey");
+    }
+
+    if (options.delay() != null) {
+      badOptionList.add("delay");
+    }
+
+    if (!badOptionList.isEmpty()) {
+      throw new IllegalArgumentException(
+          "%s invalid options without a queue name: %s"
+              .formatted(workflow.fullyQualifiedName(), String.join(", ", badOptionList)));
+    }
+
     logger.debug("executeWorkflow {}({}) {}", workflow.fullyQualifiedName(), args, options);
 
     WorkflowInitResult initResult =

transact/src/test/java/dev/dbos/transact/invocation/StartWorkflowTest.java

@@ -147,6 +147,54 @@ void invalidPartitionKey() throws Exception {
         () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
   }
 
+  @Test
+  void deduplicationIdWithoutQueue() {
+    var options = new StartWorkflowOptions().withDeduplicationId("dedupe-id");
+    assertThrows(
+        IllegalArgumentException.class,
+        () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
+  }
+
+  @Test
+  void priorityWithoutQueue() {
+    var options = new StartWorkflowOptions().withPriority(5);
+    assertThrows(
+        IllegalArgumentException.class,
+        () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
+  }
+
+  @Test
+  void queuePartitionKeyWithoutQueue() {
+    var options = new StartWorkflowOptions().withQueuePartitionKey("partition-key");
+    assertThrows(
+        IllegalArgumentException.class,
+        () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
+  }
+
+  @Test
+  void delayWithoutQueue() {
+    var options = new StartWorkflowOptions().withDelay(Duration.ofSeconds(5));
+    assertThrows(
+        IllegalArgumentException.class,
+        () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
+  }
+
+  @Test
+  void multipleQueueOptionsWithoutQueue() {
+    var options =
+        new StartWorkflowOptions()
+            .withDeduplicationId("dedupe-id")
+            .withPriority(1)
+            .withDelay(Duration.ofSeconds(5));
+    var ex =
+        assertThrows(
+            IllegalArgumentException.class,
+            () -> dbos.startWorkflow(() -> proxy.simpleWorkflow(), options));
+    assertTrue(ex.getMessage().contains("deduplicationId"));
+    assertTrue(ex.getMessage().contains("priority"));
+    assertTrue(ex.getMessage().contains("delay"));
+  }
+
   @Test
   void startWorkflowWithDelayManualTransition() throws Exception {
     var qs = DBOSTestAccess.getQueueService(dbos);

transact/src/test/java/dev/dbos/transact/queue/QueuesTest.java

@@ -2,7 +2,6 @@
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -557,31 +556,6 @@ public void testGlobalConcurrency() throws Exception {
     assertEquals(2, idsToRun.size());
   }
 
-  @Test
-  public void testQueueOptionsNotWrittenWhenNotEnqueued() throws Exception {
-    var impl = new PartitionsTestServiceImpl();
-    var proxy = dbos.registerProxy(PartitionsTestService.class, impl);
-    dbos.launch();
-
-    var options =
-        new StartWorkflowOptions()
-            .withDeduplicationId("dedupe")
-            .withDelay(Duration.ofSeconds(10))
-            .withPriority(100)
-            .withQueuePartitionKey("partition-1");
-    var handle = dbos.startWorkflow(() -> proxy.normalWorkflow(), options);
-    var result = handle.getResult();
-    assertEquals(handle.workflowId(), result);
-
-    var row = DBUtils.getWorkflowRow(dataSource, handle.workflowId());
-    assertNotNull(row);
-    assertNull(row.queueName());
-    assertNull(row.deduplicationId());
-    assertNull(row.queuePartitionKey());
-    assertEquals(0, row.priority());
-    assertNull(row.delayUntilEpochMs());
-  }
-
   @Test
   public void testenQueueWF() throws Exception {