WIP

Author: devhawk

build.gradle.kts

@@ -84,9 +84,9 @@ tasks.register("printGitStatus") {
     }
 }
 
-// tasks.register("createRelease") {
-//     group = "release"
-//     description = "Create a release branch and git tag"
+tasks.register("createRelease") {
+    group = "release"
+    description = "Create a release branch and git tag"
 
 //     if (isGitDirty) {
 //         throw GradleException("Local git repository is not clean")
@@ -115,7 +115,7 @@ tasks.register("printGitStatus") {
 //         runCommand("git", "branch", releaseBranch)
 //         runCommand("git", "push", "origin", releaseBranch)
 //     }
-// }
+}
 
 plugins {
     id("java")
@@ -161,6 +161,10 @@ tasks.withType<Pmd> {
     }
 }
 
+tasks.withType<JavaCompile>().configureEach {
+    options.compilerArgs.addAll(listOf("-Xlint:unchecked", "-Xlint:deprecation"))
+}
+
 repositories {
     gradlePluginPortal()
     mavenCentral()

src/main/java/dev/dbos/transact/context/DBOSContext.java

@@ -16,11 +16,6 @@ public class DBOSContext {
   StartWorkflowOptions startOptions;
   String startedWorkflowId;
 
-  // TODO: auth support
-  // String authenticatedUser;
-  // List<String> authenticatedRoles;
-  // String assumedRole;
-
   // current workflow fields
   private final String workflowId;
   private int functionId;

src/main/java/dev/dbos/transact/execution/DBOSExecutor.java

@@ -356,7 +356,6 @@ public <T, E extends Exception> T callFunctionAsStep(
     return functionResult;
   }
 
-  @SuppressWarnings("unchecked")
   public <T, E extends Exception> T runStepInternal(
       ThrowingSupplier<T, E> stepfunc, StepOptions opts, String childWfId) throws E {
     try {
@@ -376,7 +375,6 @@ public <T, E extends Exception> T runStepInternal(
     }
   }
 
-  @SuppressWarnings("unchecked")
   private <T, E extends Exception> T handleExistingResult(StepResult result, String functionName)
       throws E {
     if (result.getOutput() != null) {
@@ -397,7 +395,6 @@ private <T, E extends Exception> T handleExistingResult(StepResult result, Strin
     }
   }
 
-  @SuppressWarnings("unchecked")
   public <T, E extends Exception> T runStepInternal(
       String stepName,
       boolean retryAllowed,
@@ -513,8 +510,6 @@ private static <R, E extends Exception> WorkflowHandle<R, E> retrieveWorkflow(
   }
 
   public void sleep(Duration duration) {
-    // CB TODO: This should be OK outside DBOS
-
     DBOSContext context = DBOSContextHolder.get();
 
     if (context.getWorkflowId() == null) {

src/main/java/dev/dbos/transact/internal/DBOSInvocationHandler.java

@@ -28,7 +28,6 @@ public DBOSInvocationHandler(
     this.executorSupplier = executorSupplier;
   }
 
-  @SuppressWarnings("unchecked")
   public static <T> T createProxy(
       Class<T> interfaceClass,
       Object implementation,

src/main/java/dev/dbos/transact/workflow/Scheduled.java

@@ -9,7 +9,4 @@
 @Target(ElementType.METHOD)
 public @interface Scheduled {
   String cron();
-
-  // TODO: add scheduler mode enum + queueName params
-  //       https://github.com/dbos-inc/dbos-transact-java/issues/87
 }

src/main/java/dev/dbos/transact/workflow/internal/WorkflowHandleFuture.java

@@ -26,7 +26,6 @@ public String workflowId() {
     return workflowId;
   }
 
-  @SuppressWarnings("unchecked")
   @Override
   public T getResult() throws E {
     return executor.<T, E>callFunctionAsStep(

src/test/java/dev/dbos/transact/admin/AdminServerTest.java

@@ -60,7 +60,6 @@ public void ensurePostJsonNotPost() throws IOException {
 
     List<WorkflowHandle<?, ?>> handles = new ArrayList<>();
     for (int i = 0; i < 5; i++) {
-      @SuppressWarnings("unchecked")
       var handle = (WorkflowHandle<Object, Exception>) mock(WorkflowHandle.class);
       when(handle.workflowId()).thenReturn("workflow-00%d".formatted(i));
       handles.add(handle);
@@ -81,7 +80,6 @@ public void ensurePostJsonNotJson() throws IOException {
 
     List<WorkflowHandle<?, ?>> handles = new ArrayList<>();
     for (int i = 0; i < 5; i++) {
-      @SuppressWarnings("unchecked")
       var handle = (WorkflowHandle<Object, Exception>) mock(WorkflowHandle.class);
       when(handle.workflowId()).thenReturn("workflow-00%d".formatted(i));
       handles.add(handle);
@@ -158,7 +156,6 @@ public void workflowRecovery() throws IOException {
 
     List<WorkflowHandle<?, ?>> handles = new ArrayList<>();
     for (int i = 0; i < 5; i++) {
-      @SuppressWarnings("unchecked")
       var handle = (WorkflowHandle<Object, Exception>) mock(WorkflowHandle.class);
       when(handle.workflowId()).thenReturn("workflow-00%d".formatted(i));
       handles.add(handle);

src/test/java/dev/dbos/transact/conductor/ConductorTest.java

@@ -502,7 +502,6 @@ public void canFork() throws Exception {
     String workflowId = "sample-wf-id";
     String newWorkflowId = "new-" + workflowId;
 
-    @SuppressWarnings("unchecked")
     var mockHandle = (WorkflowHandle<Object, Exception>) mock(WorkflowHandle.class);
     when(mockHandle.workflowId()).thenReturn(newWorkflowId);
     when(mockExec.forkWorkflow(eq(workflowId), anyInt(), any())).thenReturn(mockHandle);

src/test/java/dev/dbos/transact/workflow/TimeoutTest.java

@@ -288,7 +288,6 @@ public void parentChildTimeOut() throws Exception {
 
     WorkflowOptions options = new WorkflowOptions(wfid1);
 
-    // TODO: https://github.com/dbos-inc/dbos-transact-java/issues/86
     assertThrows(
         Exception.class,
         () -> {