Plumb @Workflow.maxRecoveryAttempts thru to executor (#199)

Fixes #198

Author: devhawk

transact/src/main/java/dev/dbos/transact/Constants.java

@@ -18,4 +18,6 @@ public class Constants {
   public static final String DBOS_SCHEDULER_QUEUE = "schedulerQueue";
 
   public static final String SYSTEM_JDBC_URL_ENV_VAR = "DBOS_SYSTEM_JDBC_URL";
+
+  public static final int DEFAULT_MAX_RECOVERY_ATTEMPTS = 100;
 }

transact/src/main/java/dev/dbos/transact/DBOSClient.java

@@ -286,6 +286,7 @@ public <T, E extends Exception> WorkflowHandle<T, E> enqueueWorkflow(
             options.workflowName(), "EnqueueOptions workflowName must not be null"),
         Objects.requireNonNull(options.className(), "EnqueueOptions className must not be null"),
         Objects.requireNonNullElse(options.instanceName(), ""),
+        null,
         args,
         new ExecuteWorkflowOptions(
             Objects.requireNonNullElseGet(options.workflowId(), () -> UUID.randomUUID().toString()),

transact/src/main/java/dev/dbos/transact/execution/DBOSExecutor.java

@@ -892,11 +892,14 @@ public <T, E extends Exception> WorkflowHandle<T, E> executeWorkflow(
       WorkflowInfo parent,
       CompletableFuture<String> latch) {
 
+    Integer maxRetries = workflow.maxRecoveryAttempts() > 0 ? workflow.maxRecoveryAttempts() : null;
+
     if (options.queueName != null) {
       return enqueueWorkflow(
           workflow.name(),
           workflow.className(),
           workflow.instanceName(),
+          maxRetries,
           args,
           options,
           parent,
@@ -924,6 +927,7 @@ public <T, E extends Exception> WorkflowHandle<T, E> executeWorkflow(
               workflow.name(),
               workflow.className(),
               workflow.instanceName(),
+              maxRetries,
               args,
               workflowId,
               null,
@@ -1022,6 +1026,7 @@ public static <T, E extends Exception> WorkflowHandle<T, E> enqueueWorkflow(
       String name,
       String className,
       String instanceName,
+      Integer maxRetries,
       Object[] args,
       ExecuteWorkflowOptions options,
       WorkflowInfo parent,
@@ -1051,6 +1056,7 @@ public static <T, E extends Exception> WorkflowHandle<T, E> enqueueWorkflow(
           name,
           className,
           instanceName,
+          maxRetries,
           args,
           workflowId,
           queueName,
@@ -1084,6 +1090,7 @@ private static WorkflowInitResult preInvokeWorkflow(
       String workflowName,
       String className,
       String instanceName,
+      Integer maxRetries,
       Object[] inputs,
       String workflowId,
       String queueName,
@@ -1106,6 +1113,7 @@ private static WorkflowInitResult preInvokeWorkflow(
     Long deadlineEpochMs =
         queueName != null ? null : deadline != null ? deadline.toEpochMilli() : null;
 
+    final int retries = maxRetries == null ? Constants.DEFAULT_MAX_RECOVERY_ATTEMPTS : maxRetries;
     WorkflowStatusInternal workflowStatusInternal =
         new WorkflowStatusInternal(
             workflowId,
@@ -1135,7 +1143,7 @@ private static WorkflowInitResult preInvokeWorkflow(
     WorkflowInitResult[] initResult = {null};
     DbRetry.run(
         () -> {
-          initResult[0] = systemDatabase.initWorkflowStatus(workflowStatusInternal, 3);
+          initResult[0] = systemDatabase.initWorkflowStatus(workflowStatusInternal, retries);
         });
 
     if (parentWorkflow != null) {

transact/src/test/java/dev/dbos/transact/database/DisruptiveServiceImpl.java

@@ -8,13 +8,8 @@
 
 import javax.sql.DataSource;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 public class DisruptiveServiceImpl implements DisruptiveService {
 
-  private static final Logger logger = LoggerFactory.getLogger(DisruptiveServiceImpl.class);
-
   private DisruptiveService self;
   private DataSource ds;