Commit 43e9780
authored
Switch back to JDK WebSocket (#321)
Unfortunately, using Netty for web sockets creates possible headaches
for specific frameworks. For example, Helidon is using netty 4.1 but we
are on netty 4.2. Switching to the JDK provided WebSocket eliminates
this issue.
Unfortunately, there is one inefficiency from switching to JDK
WebSocket. The `onText` message receives the text in UTF-16 though it
was passed on the wire as UTF-8. Given that the import/export messages
pass gzipped, base-64 encoded Strings, the UTF-8 to 16 transform is not
needed. However, probably better to change Conductor to use binary
messages for import request / export response which would eliminate the
base64 encoding.1 parent 3af092e commit 43e9780
4 files changed
Lines changed: 604 additions & 372 deletions
File tree
- transact
- src
- main/java/dev/dbos/transact
- conductor
- json
- test/java/dev/dbos/transact/conductor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
39 | | - | |
40 | 37 | | |
41 | 38 | | |
42 | 39 | | |
| |||
0 commit comments